Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix E0284 to not use incorrect wording #71960

Merged
merged 1 commit into from
May 8, 2020
Merged

Fix E0284 to not use incorrect wording #71960

merged 1 commit into from
May 8, 2020

Conversation

estebank
Copy link
Contributor

@estebank estebank commented May 6, 2020

Fix #71584, fix #69683.

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2020
@estebank estebank added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 6, 2020
@estebank
Copy link
Contributor Author

estebank commented May 6, 2020

Nominating for backport because the current error can be incredibly misleading and the risk is low, but won't push for it too much as it is not critical.

davidtwco
davidtwco reviewed May 6, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Could you add tests for the cases in #71584 and #69683 so we can see the fixed error message? As far as I can tell, none of the stderr diffs here previously said "considering giving X a type" when it had a type (r=me after that).

@estebank
Copy link
Contributor Author

estebank commented May 7, 2020

@bors r=davidtwco

@bors
Copy link
Contributor

bors commented May 7, 2020

📌 Commit a7b03ad has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 7, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 8, 2020
@bors
Auto merge of rust-lang#71992 - Dylan-DPC:rollup-29qjvpe, r=Dylan-DPC
29630ce 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#70733 (Add Arc::{incr,decr}_strong_count)
 - rust-lang#71598 (improve Drop documentation)
 - rust-lang#71783 (Detect errors caused by `async` block in 2015 edition)
 - rust-lang#71903 (reword "possible candidate" import suggestion)
 - rust-lang#71960 (Fix E0284 to not use incorrect wording)

Failed merges:

r? @ghost
@bors bors merged commit 14cbbf3 into rust-lang:master May 8, 2020
@alecmocatta alecmocatta mentioned this pull request May 9, 2020
Closed
@estebank estebank mentioned this pull request May 13, 2020
Closed
@spastorino spastorino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 13, 2020
@spastorino
Copy link
Member

Adding T-compiler label to process the beta nomination.

@pnkfelix
Copy link
Member

unilaterally accepting for beta-backport.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 14, 2020
@Elinvynia Elinvynia mentioned this pull request May 22, 2020
Merged
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 22, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2020
@bors
Auto merge of rust-lang#72468 - Elinvynia:backport, r=Mark-Simulacrum
02c25b3 
[beta] Rollup backports

This includes:
* Fail if I/O error occurs during testing rust-lang#72089
* Fix hang in lexical_region_resolve rust-lang#72087
* Fix E0284 to not use incorrect wording rust-lang#71960
* Bump pulldown-cmark rust-lang#71682
@estebank estebank deleted the fix-E0284 branch November 9, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco left review comments

Assignees

@davidtwco davidtwco

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong error message for missed type inference Confusing error: cannot infer type for type u8
7 participants
@estebank @rust-highfive @bors @spastorino @pnkfelix @davidtwco @Mark-Simulacrum