Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all remaining compiler crates to use the rustc_foo pattern #72927

Merged
merged 4 commits into from
Jun 6, 2020
Merged

Rename all remaining compiler crates to use the rustc_foo pattern #72927

merged 4 commits into from
Jun 6, 2020

Conversation

petrochenkov
Copy link
Contributor

libarena -> librustc_arena
libfmt_macros -> librustc_parse_format
libgraphviz -> librustc_graphviz
libserialize -> librustc_serialize

Closes #71177 in particular.

@petrochenkov
Rename directories for some compiler crates from libx to librustc_x
47197d6 
libarena -> librustc_arena
libfmt_macros -> librustc_parse_format
libgraphviz -> librustc_graphviz
libserialize -> librustc_serialize
@petrochenkov
Make things build again
11d9514
@petrochenkov
Rename the crates in source code
283e5b4
@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2020
@petrochenkov
Copy link
Contributor Author

cc @rust-lang/compiler

@Mark-Simulacrum
Copy link
Member

My guess is that this will break some of the autopublishing scripts for e.g. libarena but IMO that's fine, they don't need to always work. cc @alexcrichton though (we should probably also move those into infra's hands at some point).

I sort of half want to say we should MCP this but I'm feeling like we've historically agreed on this somewhere already, and the crates being moved here seem like they're pretty unambiguous anyway.

r=me

@petrochenkov
Copy link
Contributor Author

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jun 2, 2020

📌 Commit e793b46 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2020
@bjorn3
Copy link
Member

bjorn3 commented Jun 3, 2020

libserialize -> librustc_serialize

This makes it easier to confuse it with the rustc-serialize crate on crates.io.

@Mark-Simulacrum
Copy link
Member

We no longer ship the compiled rustc artifacts to most users, so I don't expect it to be a major point of confusion.

@Dylan-DPC-zz
Copy link

@bors p=1

@bors
Copy link
Contributor

bors commented Jun 6, 2020

⌛ Testing commit e793b46 with merge 341d0e9d002eb6d4a24524c8d49eed8648f673ce...

@bors
Copy link
Contributor

bors commented Jun 6, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 6, 2020
@petrochenkov
Copy link
Contributor Author

No logs?
Looks like the "Run build" stage haven't even started.
Looks spurious.
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2020
@bors
Copy link
Contributor

bors commented Jun 6, 2020

⌛ Testing commit e793b46 with merge 118b505...

@bors
Copy link
Contributor

bors commented Jun 6, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 118b505 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 6, 2020
@bors bors merged commit 118b505 into rust-lang:master Jun 6, 2020
@bors bors mentioned this pull request Jun 6, 2020
Merged
This was referenced Jun 6, 2020
Merged
Merged
tesuji pushed a commit to tesuji/rustc that referenced this pull request Jun 9, 2020
@bors
Auto merge of rust-lang#72927 - petrochenkov:rustc, r=Mark-Simulacrum
b059c0a 
Rename all remaining compiler crates to use the `rustc_foo` pattern

libarena -> librustc_arena
libfmt_macros -> librustc_parse_format
libgraphviz -> librustc_graphviz
libserialize -> librustc_serialize

Closes rust-lang#71177 in particular.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libfmt_macros should be renamed to have a rustc_ prefix or moved into librustc_builtin_macros.
7 participants
@petrochenkov @rust-highfive @Mark-Simulacrum @bors @bjorn3 @Dylan-DPC-zz @matthewjasper