-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run-make regression test for issue #70924. #72952
run-make regression test for issue #70924. #72952
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
(okay it looks like this test won't break the windows build. I'll remove the test commit pnkfelix@56d185f now ) |
56d185f
to
94605b9
Compare
@bors r+ rollup |
📌 Commit 94605b9 has been approved by |
…70924, r=nikomatsakis run-make regression test for issue rust-lang#70924. Sometime after my PR rust-lang#72767 (to fix issue rust-lang#70924) landed, I realized that I *could* make a local regression test, thanks to `rustc --print sysroot`: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.
…70924, r=nikomatsakis run-make regression test for issue rust-lang#70924. Sometime after my PR rust-lang#72767 (to fix issue rust-lang#70924) landed, I realized that I *could* make a local regression test, thanks to `rustc --print sysroot`: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.
Failed in rollup: https://dev.azure.com/rust-lang/rust/_build/results?buildId=31133&view=logs&j=a6a2dd6f-5140-5fa9-b933-dfe57be2bdd5&t=53c32ceb-c4c2-54e8-ee5b-d47a390af72f
|
@bors r- |
argh, I specifically thought I tested windows-msvc in pnkfelix@56d185f I'll see what I can do about making this test only run on compatible platforms. And also check with the infrastructure team about what I did wrong in my attempt to do a test run. |
@bors r=nikomatsakis rollup |
📌 Commit a9d5dff has been approved by |
(the answer to what I did wrong: I added my test commit, but I never actually asked bors to do a try run! 🤦) |
…70924, r=nikomatsakis run-make regression test for issue rust-lang#70924. Sometime after my PR rust-lang#72767 (to fix issue rust-lang#70924) landed, I realized that I *could* make a local regression test, thanks to `rustc --print sysroot`: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.
…70924, r=nikomatsakis run-make regression test for issue rust-lang#70924. Sometime after my PR rust-lang#72767 (to fix issue rust-lang#70924) landed, I realized that I *could* make a local regression test, thanks to `rustc --print sysroot`: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.
…70924, r=nikomatsakis run-make regression test for issue rust-lang#70924. Sometime after my PR rust-lang#72767 (to fix issue rust-lang#70924) landed, I realized that I *could* make a local regression test, thanks to `rustc --print sysroot`: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.
…70924, r=nikomatsakis run-make regression test for issue rust-lang#70924. Sometime after my PR rust-lang#72767 (to fix issue rust-lang#70924) landed, I realized that I *could* make a local regression test, thanks to `rustc --print sysroot`: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.
…70924, r=nikomatsakis run-make regression test for issue rust-lang#70924. Sometime after my PR rust-lang#72767 (to fix issue rust-lang#70924) landed, I realized that I *could* make a local regression test, thanks to `rustc --print sysroot`: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.
…70924, r=nikomatsakis run-make regression test for issue rust-lang#70924. Sometime after my PR rust-lang#72767 (to fix issue rust-lang#70924) landed, I realized that I *could* make a local regression test, thanks to `rustc --print sysroot`: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.
…70924, r=nikomatsakis run-make regression test for issue rust-lang#70924. Sometime after my PR rust-lang#72767 (to fix issue rust-lang#70924) landed, I realized that I *could* make a local regression test, thanks to `rustc --print sysroot`: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.
This is one of only a few PRs that are in the intersection of 4 rollups that all failed the same way: #72952, #72977, #73007. The failure is on 32bit Windows, a bunch of tests show
The line number is utterly useless, it points to the macro definition (how is that possible?!?). Affected tests:
All 3 PRs in the intersection seem impossible to be the cause here, so I'd appreciate help with figuring out what is going on.^^ |
I am going to put 2 of them in a rollup so we can bisect (or trisect) which PR is causing the failure |
@bors rollup=maybe |
Rollup of 2 pull requests Successful merges: - rust-lang#72952 (run-make regression test for issue rust-lang#70924.) - rust-lang#72977 (Fix codegen tests for RISC-V) Failed merges: r? @ghost
Sometime after my PR #72767 (to fix issue #70924) landed, I realized that I could make a local regression test, thanks to
rustc --print sysroot
: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.