Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #73259

Merged
merged 15 commits into from
Jun 12, 2020
Merged

Rollup of 7 pull requests #73259

merged 15 commits into from
Jun 12, 2020

Commits on Jun 5, 2020

  1. std: Enable atomic.fence emission on wasm32

    This commit removes the `#[cfg]` guards in `atomic::fence` on wasm
    targets. Since these guards were originally added the upstream wasm
    specification for threads gained an `atomic.fence` instruction, so LLVM
    no longer panics on these intrinsics.
    
    Although there aren't a ton of tests in-repo for this right now I've
    tested locally and all of these fences generate `atomic.fence`
    instructions in wasm.
    
    Closes rust-lang#72997
    alexcrichton committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    05b2d3f View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2020

  1. Configuration menu
    Copy the full SHA
    74befd9 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Remove missed cfg(bootstrap)

    mati865 committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    377c550 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. Provide suggestion to convert numeric op LHS rather than unwrapping RHS

    Given a code
    
    ```rust
    fn foo(x: u8, y: u32) -> bool {
        x > y
    }
    fn main() {}
    ```
    
    it could be more helpful to provide a suggestion to do "u32::from(x)"
    rather than "y.try_into().unwrap()", since the latter may panic.
    
    We do this by passing the LHS of a binary expression up the stack into
    the coercion checker.
    
    Closes rust-lang#73145
    ayazhafiz committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    e243f62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c02f8a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a8f6c0 View commit details
    Browse the repository at this point in the history
  4. Add long error explanation for E0724

    Minor refactoring
    
    Minor refactoring
    
    Update src/librustc_error_codes/error_codes/E0724.md
    
    Co-authored-by: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co>
    
    Update src/librustc_error_codes/error_codes/E0724.md
    
    Co-authored-by: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co>
    
    Update src/librustc_error_codes/error_codes/E0724.md
    
    Co-authored-by: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co>
    
    Minor refactoring
    Ayush Kumar Mishra committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    68b4c03 View commit details
    Browse the repository at this point in the history
  5. Add comment about LocalDefId -> DefId

    Now there are instructions on how to convert back and forth on both
    structs, not just one.
    jyn514 committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    1d8da94 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#73033 - Amanieu:asm-tls, r=oli-obk

    Fix #[thread_local] statics as asm! sym operands
    
    The `asm!` RFC specifies that `#[thread_local]` statics may be used as `sym` operands for inline assembly.
    
    This also fixes a regression in the handling of `#[thread_local]` during monomorphization which caused link-time errors with multiple codegen units, most likely introduced by rust-lang#71192.
    
    r? @oli-obk
    Dylan-DPC authored Jun 11, 2020
    Configuration menu
    Copy the full SHA
    2e42476 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#73036 - alexcrichton:update-wasm-fence, r=M…

    …ark-Simulacrum
    
    std: Enable atomic.fence emission on wasm32
    
    This commit removes the `#[cfg]` guards in `atomic::fence` on wasm
    targets. Since these guards were originally added the upstream wasm
    specification for threads gained an `atomic.fence` instruction, so LLVM
    no longer panics on these intrinsics.
    
    Although there aren't a ton of tests in-repo for this right now I've
    tested locally and all of these fences generate `atomic.fence`
    instructions in wasm.
    
    Closes rust-lang#65687
    Closes rust-lang#72997
    Dylan-DPC authored Jun 11, 2020
    Configuration menu
    Copy the full SHA
    3b41e54 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#73163 - ayushmishra2005:61137-add-long-erro…

    …r-code-e0724, r=davidtwco
    
    Add long error explanation for E0724
    
    Add long explanation for the E0724 error code
    Part of rust-lang#61137
    Dylan-DPC authored Jun 11, 2020
    Configuration menu
    Copy the full SHA
    6baf867 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#73187 - mati865:bootstrap-cleanup, r=Mark-S…

    …imulacrum
    
    Remove missed `cfg(bootstrap)`
    Dylan-DPC authored Jun 11, 2020
    Configuration menu
    Copy the full SHA
    838d25b View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#73195 - ayazhafiz:i/73145, r=estebank

    Provide suggestion to convert numeric op LHS rather than unwrapping RHS
    
    Given a code
    
    ```rust
    fn foo(x: u8, y: u32) -> bool {
        x > y
    }
    fn main() {}
    ```
    
    it could be more helpful to provide a suggestion to do "u32::from(x)"
    rather than "y.try_into().unwrap()", since the latter may panic.
    
    We do this by passing the LHS of a binary expression up the stack into
    the coercion checker.
    
    Closes rust-lang#73145
    Dylan-DPC authored Jun 11, 2020
    Configuration menu
    Copy the full SHA
    7bdf7d0 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#73247 - LeSeulArtichaut:patch-1, r=spastorino

    Add various Zulip notifications for prioritization
    
    Adapts `triagebot.toml` for rust-lang/triagebot#616 and adds various Zulip notifications for the Prioritization WG workflow.
    We should also add indications about the procedure for handling those events, cc @rust-lang/wg-prioritization.
    
    r? @spastorino
    This should be merged as soon as possible after rust-lang/triagebot#616 is merged, cc @Mark-Simulacrum
    Dylan-DPC authored Jun 11, 2020
    Configuration menu
    Copy the full SHA
    ce99f37 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#73254 - jyn514:local-def-id-comment, r=lcnr

    Add comment about LocalDefId -> DefId
    
    Now there are instructions on how to convert back and forth on both
    structs, not just one.
    
    See also rust-lang#73076
    
    r? @lcnr
    Dylan-DPC authored Jun 11, 2020
    Configuration menu
    Copy the full SHA
    85a48d0 View commit details
    Browse the repository at this point in the history