-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #73259
Rollup of 7 pull requests #73259
Commits on Jun 5, 2020
-
std: Enable atomic.fence emission on wasm32
This commit removes the `#[cfg]` guards in `atomic::fence` on wasm targets. Since these guards were originally added the upstream wasm specification for threads gained an `atomic.fence` instruction, so LLVM no longer panics on these intrinsics. Although there aren't a ton of tests in-repo for this right now I've tested locally and all of these fences generate `atomic.fence` instructions in wasm. Closes rust-lang#72997
Configuration menu - View commit details
-
Copy full SHA for 05b2d3f - Browse repository at this point
Copy the full SHA 05b2d3fView commit details
Commits on Jun 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 74befd9 - Browse repository at this point
Copy the full SHA 74befd9View commit details
Commits on Jun 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 377c550 - Browse repository at this point
Copy the full SHA 377c550View commit details
Commits on Jun 11, 2020
-
Provide suggestion to convert numeric op LHS rather than unwrapping RHS
Given a code ```rust fn foo(x: u8, y: u32) -> bool { x > y } fn main() {} ``` it could be more helpful to provide a suggestion to do "u32::from(x)" rather than "y.try_into().unwrap()", since the latter may panic. We do this by passing the LHS of a binary expression up the stack into the coercion checker. Closes rust-lang#73145
Configuration menu - View commit details
-
Copy full SHA for e243f62 - Browse repository at this point
Copy the full SHA e243f62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c02f8a - Browse repository at this point
Copy the full SHA 0c02f8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a8f6c0 - Browse repository at this point
Copy the full SHA 3a8f6c0View commit details -
Add long error explanation for E0724
Minor refactoring Minor refactoring Update src/librustc_error_codes/error_codes/E0724.md Co-authored-by: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co> Update src/librustc_error_codes/error_codes/E0724.md Co-authored-by: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co> Update src/librustc_error_codes/error_codes/E0724.md Co-authored-by: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co> Minor refactoring
Ayush Kumar Mishra committedJun 11, 2020 Configuration menu - View commit details
-
Copy full SHA for 68b4c03 - Browse repository at this point
Copy the full SHA 68b4c03View commit details -
Add comment about LocalDefId -> DefId
Now there are instructions on how to convert back and forth on both structs, not just one.
Configuration menu - View commit details
-
Copy full SHA for 1d8da94 - Browse repository at this point
Copy the full SHA 1d8da94View commit details -
Rollup merge of rust-lang#73033 - Amanieu:asm-tls, r=oli-obk
Fix #[thread_local] statics as asm! sym operands The `asm!` RFC specifies that `#[thread_local]` statics may be used as `sym` operands for inline assembly. This also fixes a regression in the handling of `#[thread_local]` during monomorphization which caused link-time errors with multiple codegen units, most likely introduced by rust-lang#71192. r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for 2e42476 - Browse repository at this point
Copy the full SHA 2e42476View commit details -
Rollup merge of rust-lang#73036 - alexcrichton:update-wasm-fence, r=M…
…ark-Simulacrum std: Enable atomic.fence emission on wasm32 This commit removes the `#[cfg]` guards in `atomic::fence` on wasm targets. Since these guards were originally added the upstream wasm specification for threads gained an `atomic.fence` instruction, so LLVM no longer panics on these intrinsics. Although there aren't a ton of tests in-repo for this right now I've tested locally and all of these fences generate `atomic.fence` instructions in wasm. Closes rust-lang#65687 Closes rust-lang#72997
Configuration menu - View commit details
-
Copy full SHA for 3b41e54 - Browse repository at this point
Copy the full SHA 3b41e54View commit details -
Rollup merge of rust-lang#73163 - ayushmishra2005:61137-add-long-erro…
…r-code-e0724, r=davidtwco Add long error explanation for E0724 Add long explanation for the E0724 error code Part of rust-lang#61137
Configuration menu - View commit details
-
Copy full SHA for 6baf867 - Browse repository at this point
Copy the full SHA 6baf867View commit details -
Rollup merge of rust-lang#73187 - mati865:bootstrap-cleanup, r=Mark-S…
…imulacrum Remove missed `cfg(bootstrap)`
Configuration menu - View commit details
-
Copy full SHA for 838d25b - Browse repository at this point
Copy the full SHA 838d25bView commit details -
Rollup merge of rust-lang#73195 - ayazhafiz:i/73145, r=estebank
Provide suggestion to convert numeric op LHS rather than unwrapping RHS Given a code ```rust fn foo(x: u8, y: u32) -> bool { x > y } fn main() {} ``` it could be more helpful to provide a suggestion to do "u32::from(x)" rather than "y.try_into().unwrap()", since the latter may panic. We do this by passing the LHS of a binary expression up the stack into the coercion checker. Closes rust-lang#73145
Configuration menu - View commit details
-
Copy full SHA for 7bdf7d0 - Browse repository at this point
Copy the full SHA 7bdf7d0View commit details -
Rollup merge of rust-lang#73247 - LeSeulArtichaut:patch-1, r=spastorino
Add various Zulip notifications for prioritization Adapts `triagebot.toml` for rust-lang/triagebot#616 and adds various Zulip notifications for the Prioritization WG workflow. We should also add indications about the procedure for handling those events, cc @rust-lang/wg-prioritization. r? @spastorino This should be merged as soon as possible after rust-lang/triagebot#616 is merged, cc @Mark-Simulacrum
Configuration menu - View commit details
-
Copy full SHA for ce99f37 - Browse repository at this point
Copy the full SHA ce99f37View commit details -
Rollup merge of rust-lang#73254 - jyn514:local-def-id-comment, r=lcnr
Add comment about LocalDefId -> DefId Now there are instructions on how to convert back and forth on both structs, not just one. See also rust-lang#73076 r? @lcnr
Configuration menu - View commit details
-
Copy full SHA for 85a48d0 - Browse repository at this point
Copy the full SHA 85a48d0View commit details