Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #73310

Closed
wants to merge 45 commits into from
Closed

Commits on Jun 2, 2020

  1. Configuration menu
    Copy the full SHA
    4548eb8 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2020

  1. Configuration menu
    Copy the full SHA
    6f6620b View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Configuration menu
    Copy the full SHA
    fb58b7b View commit details
    Browse the repository at this point in the history
  2. Update chalk

    jackh726 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    045dfc0 View commit details
    Browse the repository at this point in the history
  3. Update chalk

    jackh726 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    6ba003e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3d73030 View commit details
    Browse the repository at this point in the history
  5. Implement fn_def_datum

    jackh726 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    2544b8c View commit details
    Browse the repository at this point in the history
  6. Remove RustDefId

    jackh726 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    7f2708c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ebdc950 View commit details
    Browse the repository at this point in the history
  8. Update Chalk

    jackh726 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    1d8264a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6172e9a View commit details
    Browse the repository at this point in the history
  10. Lower consts

    jackh726 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    7a5b939 View commit details
    Browse the repository at this point in the history
  11. Fix building

    jackh726 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    4028c21 View commit details
    Browse the repository at this point in the history
  12. Update chalk to 0.11.0

    jackh726 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    8aa2898 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    852313a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    645af62 View commit details
    Browse the repository at this point in the history
  15. Return type is bound too

    jackh726 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    4cf2833 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Configuration menu
    Copy the full SHA
    687767a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c91320f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    abf74b9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    50c422e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    17951e2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    19bb589 View commit details
    Browse the repository at this point in the history
  7. review comments: wording

    estebank committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    3cfecde View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bdfb9b1 View commit details
    Browse the repository at this point in the history
  9. Register new eror code

    estebank committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    215de3b View commit details
    Browse the repository at this point in the history
  10. small tweaks

    estebank committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    187e105 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Configuration menu
    Copy the full SHA
    6145918 View commit details
    Browse the repository at this point in the history
  2. compiletest: Add directives to detect sanitizer support

    Add needs-sanitizer-{address,leak,memory,thread} directive indicating
    that test requires target with support for specific sanitizer.
    
    This is an addition to the existing needs-sanitizer-support directive
    indicating that test requires a sanitizer runtime library.
    tmiasko committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    975f7df View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. Make fn_arg_names return Ident instead of symbol

    Also, implement this query for the local crate, not just foreign crates.
    Aaron1011 committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    754da88 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c11c35 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5902b2f View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. Run fmt

    Aaron1011 committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    4646e2d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    57b54c4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b126f32 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2020

  1. Configuration menu
    Copy the full SHA
    249a46f View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#72389 - Aaron1011:feature/move-fn-self-msg,…

    … r=nikomatsakis
    
    Explain move errors that occur due to method calls involving `self`
    
    When calling a method that takes `self` (e.g. `vec.into_iter()`), the method receiver is moved out of. If the method receiver is used again, a move error will be emitted::
    
    ```rust
    fn main() {
        let a = vec![true];
        a.into_iter();
        a;
    }
    ```
    
    emits
    
    ```
    error[E0382]: use of moved value: `a`
     --> src/main.rs:4:5
      |
    2 |     let a = vec![true];
      |         - move occurs because `a` has type `std::vec::Vec<bool>`, which does not implement the `Copy` trait
    3 |     a.into_iter();
      |     - value moved here
    4 |     a;
      |     ^ value used here after move
    ```
    
    However, the error message doesn't make it clear that the move is caused by the call to `into_iter`.
    
    This PR adds additional messages to move errors when the move is caused by using a value as the receiver of a `self` method::
    
    ```
    error[E0382]: use of moved value: `a`
       --> vec.rs:4:5
        |
    2   |     let a = vec![true];
        |         - move occurs because `a` has type `std::vec::Vec<bool>`, which does not implement the `Copy` trait
    3   |     a.into_iter();
        |     ------------- value moved due to this method call
    4   |     a;
        |     ^ value used here after move
        |
    note: this function takes `self`, which moves the receiver
       --> /home/aaron/repos/rust/src/libcore/iter/traits/collect.rs:239:5
        |
    239 |     fn into_iter(self) -> Self::IntoIter;
    ```
    
    TODO:
    
    - [x] Add special handling for `FnOnce/FnMut/Fn` - we probably don't want to point at the unstable trait methods
    - [x] Consider adding additional context for operations (e.g. `Shr::shr`) when the call was generated using the operator syntax (e.g. `a >> b`)
    - [x] Consider pointing to the method parent (impl or trait block) in addition to the method itself.
    RalfJung authored Jun 13, 2020
    Configuration menu
    Copy the full SHA
    1e89cc1 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#72804 - estebank:opaque-missing-lts-in-fn-2…

    …, r=nikomatsakis
    
    Further tweak lifetime errors involving `dyn Trait` and `impl Trait` in return position
    
    * Suggest substituting `'static` lifetime in impl/dyn `Trait + 'static` instead of `Trait + 'static + '_`
    * When `'static` is explicit, also suggest constraining argument with it
    * Reduce verbosity of suggestion message and mention lifetime in label
    * Tweak output for overlapping required/captured spans
    * Give these errors an error code
    
    Follow up to rust-lang#72543.
    
    r? @nikomatsakis
    RalfJung authored Jun 13, 2020
    Configuration menu
    Copy the full SHA
    6beb38a View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#72932 - poliorcetics:pattern-contains-behav…

    …iour, r=hanna-kruppe
    
    Clarify the behaviour of Pattern when used with methods like str::contains
    
    Fixes rust-lang#45507.
    
    I used the previous work by @Emerentius (thanks !), added a paragraph and checked the links (they work for me but I'm not against someone else checking them too).
    RalfJung authored Jun 13, 2020
    Configuration menu
    Copy the full SHA
    fead5f8 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#72936 - jackh726:chalk-more, r=nikomatsakis

    Upgrade Chalk
    
    Things done in this PR:
    - Upgrade Chalk to `0.11.0`
    - Added compare-mode=chalk
    - Bump rustc-hash in `librustc_data_structures` to `1.1.0` to match Chalk
    - Removed `RustDefId` since the builtin type support is there
    - Add a few more `FIXME(chalk)`s for problem spots I hit when running all tests with chalk
    - Added some more implementation code for some newer builtin Chalk types (e.g. `FnDef`, `Array`)
    - Lower `RegionOutlives` and `ObjectSafe` predicates
    - Lower `Dyn` without the region
    - Handle `Int`/`Float` `CanonicalVarKind`s
    - Uncomment some Chalk tests that actually work now
    - Remove the revisions in `src/test/ui/coherence/coherence-subtyping.rs` since they aren't doing anything different
    
    r? @nikomatsakis
    RalfJung authored Jun 13, 2020
    Configuration menu
    Copy the full SHA
    7b31dbf View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#73044 - tmiasko:compiletest-san, r=nikomats…

    …akis
    
    compiletest: Add directives to detect sanitizer support
    
    Add needs-sanitizer-{address,leak,memory,thread} directive indicating
    that test requires target with support for specific sanitizer.
    
    This is an addition to the existing needs-sanitizer-support directive
    indicating that test requires a sanitizer runtime library.
    
    The existing needs-sanitizer-support directive could be incorporated into the
    new ones, but I decided to retain it, since it enables running sanitizer
    codegen tests even when building of sanitizer runtime libraries is disabled.
    RalfJung authored Jun 13, 2020
    Configuration menu
    Copy the full SHA
    cbbc200 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#73086 - trevyn:apple-a7, r=nikic

    Rename "cyclone" to "apple-a7" per changes in upstream LLVM
    
    It looks like they intended to keep "cyclone" as a legacy option, but removed it from the list of subtarget features. This created a flood of warnings when targeting aarch64-apple-ios, and probably also created incorrectly optimized artifacts.
    
    See:
    https://reviews.llvm.org/D70779
    https://reviews.llvm.org/D70779#C1703593NL568
    
    LLVM 10 merged into master at:
    rust-lang#67759
    RalfJung authored Jun 13, 2020
    Configuration menu
    Copy the full SHA
    dad3622 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#73267 - ehuss:cargotest-this-cargo, r=Mark-…

    …Simulacrum
    
    Use the built cargo for cargotest.
    
    cargotest was using the beta (bootstrap) cargo. This changes it so that it will use the locally built cargo. This is intended to provide a sort of smoke test to ensure Cargo is functional. This *shouldn't* have any real impact on the CI build time.  The cargotest job also happens to run cargo's testsuite, so it should already be building cargo.
    
    Note: This will fail until rust-lang#73266 is merged.
    RalfJung authored Jun 13, 2020
    Configuration menu
    Copy the full SHA
    b3c4f41 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#73290 - LeSeulArtichaut:patch-1, r=Dylan-DPC

    Fix links when pinging notification groups
    
    I think a blank line is necessary for the link to be applied.
    Not sure who to assign, r? @Dylan-DPC
    RalfJung authored Jun 13, 2020
    Configuration menu
    Copy the full SHA
    d8091e3 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#73308 - yerke:fix-pretty-asm-rs-test-for-aa…

    …rch64, r=Amanieu
    
    pretty/asm.rs should only be tested for x86_64 and not AArch64
    
    pretty/asm.rs should only be tested for x86_64 and not AArch64
    closes rust-lang#73134
    r?  @Amanieu
    RalfJung authored Jun 13, 2020
    Configuration menu
    Copy the full SHA
    d63778d View commit details
    Browse the repository at this point in the history