Don't use DesugaringKind to track desugared operators
#73571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
See rust-lang#73468 (comment) This removes the immediate need for PR rust-lang#73468, since Clippy will no longer be confused by the precense of a new `ExpnId` 'on top of' a macro expansion `ExpnId`. This makes some of the 'self move diagnostics' added by PR rust-lang#72389 slightly worse. I've left the operator-related diagnostics code in place, so it should be easy for a followup PR to plug in a new way of detecting desugared operators.
Aaron1011
force-pushed
the
remove-operator-desugar-span
branch
from
c7d9205
to
571beb4
Compare
|
Meta: it is hard to see what ends up in master if the changes are submitted like this. I see that not all changes in hygiene.rs and AST lowering are reverted, so now I need to go through two PRs simultaneously and compare the diffs. This is not a work that I'd want to do on this great Sunday. Could you just submit a revert of #72389 (+ a commit re-enabling clippy tests, I'll r+ it immediately then), and then re-land it as a separate PR some time later. |
petrochenkov
added
S-waiting-on-author
|
Closing in favor of #73594. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #73468 (comment)
This removes the immediate need for PR #73468, since Clippy will no
longer be confused by the precense of a new
ExpnId'on top of' amacro expansion
ExpnId.This makes some of the 'self move diagnostics' added by PR #72389
slightly worse. I've left the operator-related diagnostics code in
place, so it should be easy for a followup PR to plug in a new way of
detecting desugared operators.