Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add read_exact_at and write_all_at to WASI's FileExt #74076

Merged
merged 2 commits into from
Jul 11, 2020
Merged

Add read_exact_at and write_all_at to WASI's FileExt #74076

merged 2 commits into from
Jul 11, 2020

Commits on Jul 7, 2020

  1. Add read_exact_at and write_all_at to WASI's FileExt 

    This adds `read_exact_at` and `write_all_at` to WASI's `FileExt`,
similar to the Unix versions of the same names.
    @sunfishcode
    sunfishcode committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    653c091 View commit details
    Browse the repository at this point in the history

  2. Make WASI's FileExt's read_at/write_at consistent with other targets. 

    Rename the existing read_at/write_at to read_vectored_at/write_vectored_at,
for consistency with libstd's read_vectored/write_vectored. And,
introduce new read_at/write_at functions which take a single buffer,
similar to all other targets which provide these functions, so this will
make it easier for applications to share code between WASI and other
targets.

Note that WASI's FileExt is currently unstable.
    @sunfishcode
    sunfishcode committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    58fc61b View commit details
    Browse the repository at this point in the history