-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use relative path for local links to primitives #74077
Use relative path for local links to primitives #74077
Commits on Jul 6, 2020
-
Use relative path for local links to primitives in libcore
Else, links to `char::foo` would point into `/path/to/src/libcore/std/primitive.char.html#method.foo`. Split out from rust-lang#73804.
Configuration menu - View commit details
-
Copy full SHA for 81fbfc4 - Browse repository at this point
Copy the full SHA 81fbfc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee3a0f8 - Browse repository at this point
Copy the full SHA ee3a0f8View commit details
Commits on Jul 7, 2020
-
Two new rustdoc tests for intra links
They both produce less-than-desirable output (links going to docs.rust-lang.org), but I haven't figured out yet how to assert about them properly.
Configuration menu - View commit details
-
Copy full SHA for 33a5d00 - Browse repository at this point
Copy the full SHA 33a5d00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 165aecb - Browse repository at this point
Copy the full SHA 165aecbView commit details -
Assert current behavior for links
For the two of these tests that have a local `char` to link to, this behavior isn't what's expected, but is what's happening presently.
Configuration menu - View commit details
-
Copy full SHA for 865b930 - Browse repository at this point
Copy the full SHA 865b930View commit details -
Configuration menu - View commit details
-
Copy full SHA for f258d98 - Browse repository at this point
Copy the full SHA f258d98View commit details -
Revert "Add guard to check for local
core
crate"This reverts commit ee3a0f8.
Configuration menu - View commit details
-
Copy full SHA for 8d267db - Browse repository at this point
Copy the full SHA 8d267dbView commit details
Commits on Jul 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9366458 - Browse repository at this point
Copy the full SHA 9366458View commit details -
Avoid running test on Windows platforms
There don't seem to be any other compiletests that are 1) building a standalone "no_core" create and then 2) trying to link against it. There seems to be a platform-specific limitation in doing so: ``` 2020-07-08T16:07:42.9419409Z = note: Creating library D:\a\rust\rust\build\i686-pc-windows-msvc\test\rustdoc\intra-link-prim-methods-external-core\auxiliary\my_core.dll.lib and object D:\a\rust\rust\build\i686-pc-windows-msvc\test\rustdoc\intra-link-prim-methods-external-core\auxiliary\my_core.dll.exp 2020-07-08T16:07:42.9419810Z LINK : error LNK2001: unresolved external symbol __DllMainCRTStartup@12 2020-07-08T16:07:42.9420032Z D:\a\rust\rust\build\i686-pc-windows-msvc\test\rustdoc\intra-link-prim-methods-external-core\auxiliary\my_core.dll : fatal error LNK1120: 1 unresolved externals ``` Possibly this could be resolved by adding a `__DllMainCRTStartup` or `__DllMainCRTStartup@12` symbol in an architecture- and platform-specific way.
Configuration menu - View commit details
-
Copy full SHA for 56b6b44 - Browse repository at this point
Copy the full SHA 56b6b44View commit details