Unstably allow assume intrinsic in const contexts #76973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Sep 20, 2020
tesuji
force-pushed
the
unstably-const-assume
branch
from
7d25016
to
4bb75dd
Compare
3 tasks
tesuji
force-pushed
the
unstably-const-assume
branch
from
4bb75dd
to
a3f87fc
Compare
RalfJung
reviewed
Sep 20, 2020
tesuji
force-pushed
the
unstably-const-assume
branch
from
a3f87fc
to
c2390c9
Compare
RalfJung
reviewed
Sep 20, 2020
| pub const unsafe fn foo(x: usize, y: usize) -> usize { | ||
| assume(y != 0); | ||
| x / y | ||
| } |
There was a problem hiding this comment.
Isn't this the kind of test that should be made a unit test instead (#76268)?
There was a problem hiding this comment.
I only saw const_slice_from_raw_parts and const_raw_ptr_deref in library/core/tests/lib.rs.
Not really sure about this.
There was a problem hiding this comment.
Yeah, I think this should be a unit-test.
There was a problem hiding this comment.
It's kind of weird since most intrinsics not tested in library/core/tests.
Anyway, I moved it.
oli-obk
reviewed
Sep 20, 2020
|
Not sure the block optimization concerns about adding assume to |
|
Because the above concern isn't resolved, I will move the |
|
Yea they probably do :( I don't think there's any point in summoning nagisa or hanna, I don't think anything changed over the last two years that woudl affect this. |
tesuji
force-pushed
the
unstably-const-assume
branch
from
c2390c9
to
4387480
Compare
|
@bors r+ |
|
📌 Commit 382d724 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Sep 25, 2020
…-obk Unstably allow assume intrinsic in const contexts Not sure much about this usage because there are concerns about [blocking optimization][1] and [slowing down LLVM][2] when using `assme` intrinsic in inline functions. But since Oli suggested in rust-lang#76960 (comment), here we are. [1]: rust-lang#54995 (comment) [2]: rust-lang#49572 (comment)
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Sep 25, 2020
…-obk Unstably allow assume intrinsic in const contexts Not sure much about this usage because there are concerns about [blocking optimization][1] and [slowing down LLVM][2] when using `assme` intrinsic in inline functions. But since Oli suggested in rust-lang#76960 (comment), here we are. [1]: rust-lang#54995 (comment) [2]: rust-lang#49572 (comment)
This was referenced Sep 25, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2020
…as-schievink Rollup of 15 pull requests Successful merges: - rust-lang#76932 (Relax promises about condition variable.) - rust-lang#76973 (Unstably allow assume intrinsic in const contexts) - rust-lang#77005 (BtreeMap: refactoring around edges) - rust-lang#77066 (Fix dest prop miscompilation around references) - rust-lang#77073 (dead_code: look at trait impls even if they don't contain items) - rust-lang#77086 (Include libunwind in the rust-src component.) - rust-lang#77097 (Make [].as_[mut_]ptr_range() (unstably) const.) - rust-lang#77106 (clarify that `changelog-seen = 1` goes to the beginning of config.toml) - rust-lang#77120 (Add `--keep-stage-std` to `x.py` for keeping only standard library artifacts) - rust-lang#77126 (Invalidate local LLVM cache less often) - rust-lang#77146 (Install std for non-host targets) - rust-lang#77155 (remove enum name from ImplSource variants) - rust-lang#77176 (Removing erroneous semicolon in transmute documentation) - rust-lang#77183 (Allow multiple allow_internal_unstable attributes) - rust-lang#77189 (Remove extra space from vec drawing) Failed merges: r? `@ghost`
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Sep 27, 2020
Remove assume intrinsic from EvalContextExt Waiting for rust-lang/rust#76973 merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure much about this usage because there are concerns
about blocking optimization and slowing down LLVM when using
assmeintrinsicin inline functions.
But since Oli suggested in #76960 (comment),
here we are.