This pull request activates hygiene for 'let' bindings. argument bindings come soon #7745
Conversation
| mod test { | ||
| // just test to see if it compiles: | ||
| #[test] fn iterbytes_compiles () { | ||
| let a : @IterBytes = @(3,4,5,false); |
There was a problem hiding this comment.
This probably doesn't compile: it might need an explicit cast (i.e. @(3,4,5,false) as @IterBytes), and may even need the types of the integer literals to be specified (i.e. 1i) but I'm not sure about this one:
rusti> let a: @IterBytes = @(1i, 2i);
<anon>:14:20: 14:27 error: mismatched types: expected `@std::to_bytes::IterBytes:'static` but found `@(<VI0>,<VI1>)` (expected trait std::to_bytes::IterBytes but found @-ptr)
<anon>:14 let a: @IterBytes = @(1, 2);
^~~~~~~
|
Overall looks good to me, but this isn't my area of expertise. |
|
Unfortunately this ICEs in my local workspace. Reviewing and diagnosing as best I can.. |
|
On Jul 12, 2013, at 8:50 AM, Graydon Hoare wrote:
Details? Duplicating your ICE and fixing the bug is my top priority right now. John |
|
Make check. Ice on compiling stage 2 stdtest. |
|
On Jul 12, 2013, at 9:46 AM, Graydon Hoare wrote:
Got it. I think I have the fix for this. (Make check was in the middle of run-fail on my small laptop when I passed out last night.) John |
also adds test cases
…e comparison in others
resolve must ignore syntax context when comparing module names
this is necessary so that the new idents are connected to the original strings. this is important both for error messages, and so that top-level refs get connected to the right things.
|
Successfully rebased, make check succeeds without complaint. |
|
Also, for ease in reviewing: da2ed92 represents the head of this PR (for now, at least) |
|
Continued in #8103 |
Useless exponent Closes rust-lang#7745 I'm open to some thoughts on dropping the exponents on suggestions when it's zero. I personally don't see any problem on this. changelog: [`useless_exponent`] suggestion drops exponent when exponent value is zero
There are a bunch of commits here, but I believe they're all well-labeled and focused. As I'm leaving now-ish, I'm going to beg for quick review.