Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove storage markers if they won't be used during code generation #78360

Merged
merged 3 commits into from
Mar 1, 2021
Merged

Remove storage markers if they won't be used during code generation #78360

merged 3 commits into from
Mar 1, 2021

Commits on Feb 28, 2021

  1. Remove storage markers if they won't be used during code generation 

    The storage markers constitute a substantial portion of all MIR
statements. At the same time, for builds without any optimizations,
the storage markers have no further use during and after MIR
optimization phase.

If storage markers are not necessary for code generation, remove them.
    @tmiasko
    tmiasko committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    8b184ff View commit details
    Browse the repository at this point in the history

  2. compiletest: run mir-opt tests with -C opt-level=1 

    The storage markers are removed at -C opt-level=0 and as a result output
of mir opt tests vary based on used optimization level. Use opt-level=1
for mir-opt tests to avoid the issue.
    @tmiasko
    tmiasko committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    7076050 View commit details
    Browse the repository at this point in the history

  3. Use -O in try_identity test that requires storage markers

    @tmiasko
    tmiasko committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    57de468 View commit details
    Browse the repository at this point in the history