Convert ivec type syntax from T[] to [T] #806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. Working on integrating it now. |
|
I don't think I'm going to get to this today. The windows build is broken so we can't snapshot. |
|
No rush, thanks for looking into this :) On Fri, Aug 5, 2011 at 4:53 PM, brson
|
This preserves the old syntax for now.
|
By the way, I re-rebased this patch on top of the graydon/master. |
|
I've pushed the pre-snapshot commits. Still waiting for the right conditions to do the snapshot. |
|
Integrated. |
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this pull request
Dec 12, 2017
define SYS_renameat2 + flags on linux Motivation: there is no glibc wrapper for this syscall
bjorn3
added a commit
to bjorn3/rust
that referenced
this pull request
Mar 5, 2021
bjorn3
added a commit
to bjorn3/rust
that referenced
this pull request
Mar 20, 2022
ZuseZ4
pushed a commit
to EnzymeAD/rust
that referenced
this pull request
Mar 7, 2023
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first attempt at converting the ivec type syntax from T[] to [T]. It seems to work with a check-full, so I expect no problems. There are three phases to this commit. First is adding support for the syntax [T]. Then, all the code is converted over to the [T] syntax. Finally, support for T[] is removed.
As a word of caution, the commit 4ea04c9 (Change the ivec type syntax to [T]) needs a stage 3 snapshot made before the rest of the commits can be committed.
Please let me know if you need any tweaks.