-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #82330
Rollup of 10 pull requests #82330
Commits on Feb 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f165f49 - Browse repository at this point
Copy the full SHA f165f49View commit details -
Configuration menu - View commit details
-
Copy full SHA for f30c51a - Browse repository at this point
Copy the full SHA f30c51aView commit details
Commits on Feb 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cadcf5e - Browse repository at this point
Copy the full SHA cadcf5eView commit details
Commits on Feb 11, 2021
-
Make WASI's
hard_link
behavior match other platforms.Following rust-lang#78026, `std::fs::hard_link` on most platforms does not follow symlinks. Change the WASI implementation to also not follow symlinks.
Configuration menu - View commit details
-
Copy full SHA for 0060c91 - Browse repository at this point
Copy the full SHA 0060c91View commit details
Commits on Feb 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for daa55ac - Browse repository at this point
Copy the full SHA daa55acView commit details
Commits on Feb 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for eace240 - Browse repository at this point
Copy the full SHA eace240View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33d8b04 - Browse repository at this point
Copy the full SHA 33d8b04View commit details
Commits on Feb 15, 2021
-
Add internal
collect_into_array[_unchecked]
to remove duplicate codeThis does not suggest adding such a function to the public API. This is just for the purpose of avoiding duplicate code. Many array methods already contained the same kind of code and there are still many array related methods to come (e.g. `Iterator::{chunks, map_windows, next_n, ...}`) which all basically need this functionality. Writing custom `unsafe` code for each of those seems not like a good idea.
Configuration menu - View commit details
-
Copy full SHA for c675af8 - Browse repository at this point
Copy the full SHA c675af8View commit details
Commits on Feb 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 30c5125 - Browse repository at this point
Copy the full SHA 30c5125View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ec4b06 - Browse repository at this point
Copy the full SHA 5ec4b06View commit details -
Configuration menu - View commit details
-
Copy full SHA for b08bc78 - Browse repository at this point
Copy the full SHA b08bc78View commit details
Commits on Feb 18, 2021
-
Fix panic in 'remove semicolon' when types are not local
It's not possible to check if removing a semicolon fixes the type error when checking match arms and one or both of the last arm's and the current arm's return types are imported "opaque" types. In these cases we don't generate a "consider removing semicolon" suggestions. Fixes rust-lang#81839
Configuration menu - View commit details
-
Copy full SHA for 5fd1ebe - Browse repository at this point
Copy the full SHA 5fd1ebeView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad47fb1 - Browse repository at this point
Copy the full SHA ad47fb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15fdccc - Browse repository at this point
Copy the full SHA 15fdcccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ef67e0 - Browse repository at this point
Copy the full SHA 9ef67e0View commit details
Commits on Feb 19, 2021
-
Consider auto derefs before warning about write only fields
Changes from 81473 extended the dead code lint with an ability to detect fields that are written to but never read from. The implementation skips over fields on the left hand side of an assignment, without marking them as live. A field access might involve an automatic dereference and de-facto read the field. Conservatively mark expressions with deref adjustments as live to avoid generating false positive warnings.
Configuration menu - View commit details
-
Copy full SHA for 343b673 - Browse repository at this point
Copy the full SHA 343b673View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48b5c09 - Browse repository at this point
Copy the full SHA 48b5c09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 597118b - Browse repository at this point
Copy the full SHA 597118bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62ee3ec - Browse repository at this point
Copy the full SHA 62ee3ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1abcdfe - Browse repository at this point
Copy the full SHA 1abcdfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fddc2f - Browse repository at this point
Copy the full SHA 0fddc2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3000ec - Browse repository at this point
Copy the full SHA b3000ecView commit details
Commits on Feb 20, 2021
-
impl PartialEq<Punct> for char
; symmetry for rust-lang#78636Also fixes the "since" version of the original.
Configuration menu - View commit details
-
Copy full SHA for 1839748 - Browse repository at this point
Copy the full SHA 1839748View commit details -
Configuration menu - View commit details
-
Copy full SHA for e906745 - Browse repository at this point
Copy the full SHA e906745View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9c6188 - Browse repository at this point
Copy the full SHA a9c6188View commit details -
Rollup merge of rust-lang#80595 - pthariensflame:patch-1, r=m-ou-se
`impl PartialEq<Punct> for char`; symmetry for rust-lang#78636 Also fixes the "since" version of the original. Pinging `@dtolnay` and `@petrochenkov.`
Configuration menu - View commit details
-
Copy full SHA for e37adf5 - Browse repository at this point
Copy the full SHA e37adf5View commit details -
Rollup merge of rust-lang#81837 - gilescope:to_ascii_speedups, r=dtolnay
Slight perf improvement on char::to_ascii_lowercase `char::to_ascii_lowercase()` was checking if it was ascii and then if it was in the right range. Instead propose to check once (I think removing a compare and a shift in the process: [godbolt](https://godbolt.org/z/e5Tora) ). before: ``` test char::methods::bench_to_ascii_lowercase ... bench: 11,196 ns/iter (+/- 632) test char::methods::bench_to_ascii_uppercase ... bench: 11,656 ns/iter (+/- 671) ``` after: ``` test char::methods::bench_to_ascii_lowercase ... bench: 9,612 ns/iter (+/- 979) test char::methods::bench_to_ascii_uppercase ... bench: 8,241 ns/iter (+/- 701) ``` (calling u8::to_ascii_lowercase and letting that flip the 5th bit is also an option, but it's more instructions. I'm thinking for things around ascii and char we want to be as efficient as possible.)
Configuration menu - View commit details
-
Copy full SHA for 6468333 - Browse repository at this point
Copy the full SHA 6468333View commit details -
Rollup merge of rust-lang#81984 - sunfishcode:wasi-link, r=alexcrichton
Make WASI's `hard_link` behavior match other platforms. Following rust-lang#78026, `std::fs::hard_link` on most platforms does not follow symlinks. Change the WASI implementation to also not follow symlinks. r? `@alexcrichton`
Configuration menu - View commit details
-
Copy full SHA for b7b2d58 - Browse repository at this point
Copy the full SHA b7b2d58View commit details -
Rollup merge of rust-lang#81991 - osa1:issue81839, r=estebank
Fix panic in 'remove semicolon' when types are not local It's not possible to check if removing a semicolon fixes the type error when checking match arms and one or both of the last arm's and the current arm's return types are imported "opaque" types. In these cases we don't generate a "consider removing semicolon" suggestions. Fixes rust-lang#81839 --- I'm not sure how to add a test for this. I think the test would need at least two crates. Do we have any existing tests that do this so that I can take a look?
Configuration menu - View commit details
-
Copy full SHA for 71ee3c8 - Browse repository at this point
Copy the full SHA 71ee3c8View commit details -
Rollup merge of rust-lang#82091 - henryboisdequin:use-place-ref-more,…
… r=RalfJung use PlaceRef abstractions more consistently Addresses this [comment](https://github.com/rust-lang/rust/pull/80865/files#r558978715) Associated issue: rust-lang#80647 r? `@RalfJung`
Configuration menu - View commit details
-
Copy full SHA for 06e04fd - Browse repository at this point
Copy the full SHA 06e04fdView commit details -
Rollup merge of rust-lang#82098 - LukasKalbertodt:add-collect-into-ar…
…ray, r=dtolnay Add internal `collect_into_array[_unchecked]` to remove duplicate code Unlike the similar PRs rust-lang#69985, rust-lang#75644 and rust-lang#79659, this PR only adds private functions and does not propose any new public API. The change is just for the purpose of avoiding duplicate code. Many array methods already contained the same kind of code and there are still many array related methods to come (e.g. `Iterator::{chunks, map_windows, next_n, ...}`, `[T; N]::{cloned, copied, ...}`, ...) which all basically need this functionality. Writing custom `unsafe` code for each of those doesn't seem like a good idea. I added two functions in this PR (and not just the `unsafe` version) because I already know that I need the `Option`-returning version for `Iterator::map_windows`. This is closely related to rust-lang#81615. I think that all options listed in that issue can be implemented using the function added in this PR. The only instance where `collect_array_into` might not be general enough is when the caller want to handle incomplete arrays manually. Currently, if `iter` yields fewer than `N` items, `None` is returned and the already yielded items are dropped. But as this is just a private function, it can be made more general in future PRs. And while this was not the goal, this seems to lead to better assembly for `array::map`: https://rust.godbolt.org/z/75qKTa (CC `@JulianKnodt)` Let me know what you think :) CC `@matklad` `@bstrie`
Configuration menu - View commit details
-
Copy full SHA for bb89479 - Browse repository at this point
Copy the full SHA bb89479View commit details -
Rollup merge of rust-lang#82166 - kaniini:s390x-musl-target, r=nagisa
add s390x-unknown-linux-musl target This is the first step in bringup for Rust on s390x. The libc and std crates need modifications as well, but getting this upstream makes that work easier.
Configuration menu - View commit details
-
Copy full SHA for 886e995 - Browse repository at this point
Copy the full SHA 886e995View commit details -
Rollup merge of rust-lang#82176 - RalfJung:mir-fn-ptr-pretty, r=oli-obk
fix MIR fn-ptr pretty-printing An uninitialized function pointer would get printed as `{{uninit fn()}` (notice the unbalanced parentheses), and a dangling fn ptr would ICE. This fixes both of that. However, I have no idea how to add tests for this. Also, I don't understand this MIR pretty-printing code. Somehow the print function `pretty_print_const_scalar` actually *returns* a transformed form of the const (but there is no doc comment explaining what is being returned); some match arms do `p!` while others do `self =`, and there's a wild mixture of `p!` and `write!`... all very mysterious and confusing.^^ r? `@oli-obk`
Configuration menu - View commit details
-
Copy full SHA for 7109440 - Browse repository at this point
Copy the full SHA 7109440View commit details -
Rollup merge of rust-lang#82296 - spastorino:pubrules, r=nikomatsakis
Support `pub` on `macro_rules` This rebases and updates `since` version of rust-lang#78166 from `@petrochenkov` r? `@nikomatsakis`
Configuration menu - View commit details
-
Copy full SHA for 50272eb - Browse repository at this point
Copy the full SHA 50272ebView commit details -
Rollup merge of rust-lang#82297 - tmiasko:write-only, r=oli-obk
Consider auto derefs before warning about write only fields Changes from rust-lang#81473 extended the dead code lint with an ability to detect fields that are written to but never read from. The implementation skips over fields on the left hand side of an assignment, without marking them as live. A field access might involve an automatic dereference and de-facto read the field. Conservatively mark expressions with deref adjustments as live to avoid generating false positive warnings. Closes rust-lang#81626.
Configuration menu - View commit details
-
Copy full SHA for 3b80aef - Browse repository at this point
Copy the full SHA 3b80aefView commit details