diagnostics: Be clear about "crate root" and ::foo paths in resolve diagnostics
#82881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve diagnostics (for bare `::foo`)
…ve diagnostics for ::foo::Bar
|
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try I ran most of the relevant tests but I probably missed something |
|
⌛ Trying commit 249e84806f6f8854468dcfd35944034e5920c19e with merge 7cc1252e91642661873c8193c2d8b36284383347... |
This comment has been minimized.
This comment has been minimized.
… on crate imports in 2018
|
@bors try |
|
⌛ Trying commit 0eeae1a with merge a4735d68b007154912ef3c8b5d978586d26e2643... |
|
☀️ Try build successful - checks-actions |
|
📌 Commit 0eeae1a has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 9, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#82711 (Add documentation for string->Cow conversions) - rust-lang#82767 (Update minifier dependency version) - rust-lang#82800 (Move rustdoc UI tests into a subdirectory) - rust-lang#82810 (Typo fix in Unstable book: `cargo cov` -> `cargo profdata`) - rust-lang#82829 (Handle negative literals in cast overflow warning) - rust-lang#82854 (Account for `if (let pat = expr) {}`) - rust-lang#82870 (Add note about the `#[doc(no-inline)]` usage) - rust-lang#82874 (Add codegen tests for some issues closed by LLVM 12) - rust-lang#82881 (diagnostics: Be clear about "crate root" and `::foo` paths in resolve diagnostics) - rust-lang#82888 (Grammar Fixes) - rust-lang#82897 ([.mailmap] Add entry for Ramkumar Ramachandra) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes to make sure the diagnostics are clear about the differences in
::foopaths across editions:::foowill say "crate root" in 2015 and "list of imported crates" in 2018crate::will never reference imported crates in 2018Fixes #82876