Cross compiling rustc_llvm on Darwin requires zlib. #86072
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthewjasper (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
We require PR branches to not contain merge commits. It should be rebased instead. https://rustc-dev-guide.rust-lang.org/contributing.html#opening-a-pr |
MarcusCalhoun-Lopez
force-pushed
the
llvm_cross
branch
from
07ab51b
to
956fd10
Compare
|
Sorry, Git is still somewhat of a mystery to me. |
|
Yes, the commit history is fine now. |
JohnCSimon
added
S-waiting-on-review
|
Triage: Is this still waiting on review? |
|
r? @nagisa |
|
@bors r+ rollup |
|
📌 Commit 956fd10 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 9 pull requests Successful merges: - rust-lang#86072 (Cross compiling rustc_llvm on Darwin requires zlib.) - rust-lang#87385 (Make `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` warn by default) - rust-lang#87547 (Add missing examples for NonNull) - rust-lang#87557 (Fix issue with autofix for ambiguous associated function from Rust 2021 prelude when struct is generic) - rust-lang#87559 (Tweak borrowing suggestion in `for` loop) - rust-lang#87596 (Add warning when whitespace is not skipped after an escaped newline) - rust-lang#87606 (Add some TAIT-related regression tests) - rust-lang#87609 (Add docs about performance and `Iterator::map` to `[T; N]::map`) - rust-lang#87616 (Fix missing word in rustdoc book) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
No description provided.