Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy lints #89405

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Fix clippy lints #89405

merged 1 commit into from
Oct 2, 2021

Conversation

GuillaumeGomez
Copy link
Member

I'm currently working on allowing clippy to run on librustdoc after a discussion I had with @Mark-Simulacrum. So in the meantime, I fixed a few lints on the compiler crates.

@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 30, 2021
@rust-highfive
Copy link
Collaborator

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2021
@cjgillot
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 30, 2021

📌 Commit fb656b2856eeda61c3aa36fa6d2ac67ac03f2bee has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2021
@Mark-Simulacrum
Copy link
Member

@bors rollup=never -- with this many changes we could get weird perf effects, though hopefully not

@bors
Copy link
Contributor

bors commented Oct 1, 2021

⌛ Testing commit fb656b2856eeda61c3aa36fa6d2ac67ac03f2bee with merge 24bbf29cb149e63a9a530d7e3e227235f64c87f8...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Oct 1, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 1, 2021
@GuillaumeGomez
Copy link
Member Author

Seems spurious...

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2021
@bors
Copy link
Contributor

bors commented Oct 1, 2021

☔ The latest upstream changes (presumably #89435) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 1, 2021
@GuillaumeGomez
Copy link
Member Author

@bors r=cjgillot

@bors
Copy link
Contributor

bors commented Oct 1, 2021

📌 Commit 759eba0 has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 1, 2021
@bors
Copy link
Contributor

bors commented Oct 2, 2021

⌛ Testing commit 759eba0 with merge b27661e...

@bors
Copy link
Contributor

bors commented Oct 2, 2021

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing b27661e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 2, 2021
@bors bors merged commit b27661e into rust-lang:master Oct 2, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 2, 2021
@GuillaumeGomez GuillaumeGomez deleted the fix-clippy-lints branch October 2, 2021 13:40
This was referenced Oct 2, 2021
Merged
Merged
Merged
Merged
Closed
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b27661e): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@GuillaumeGomez
Copy link
Member Author

Seems like there is a small perf regression, no?

@Mark-Simulacrum Mark-Simulacrum added the perf-regression Performance regression. label Oct 5, 2021
@Mark-Simulacrum
Copy link
Member

Indeed, our heuristics did not deem this definite, but did consider it probable. We're working on those.

Tagging as a regression. Likely to be painful to investigate, but we'll see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.
8 participants
@GuillaumeGomez @rust-highfive @cjgillot @bors @Mark-Simulacrum @rust-log-analyzer @rust-timer @rustbot