Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also gate AllocatedPointer and AllocAlign definitions by LLVM_VERSION_GE #99956

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

est31
Copy link
Member

@est31 est31 commented Jul 30, 2022

Fixes a warning:

warning: llvm-wrapper/RustWrapper.cpp:159:11: warning: enumeration values 'AllocatedPointer' and 'AllocAlign' not handled in switch [-Wswitch]
warning:   switch (Kind) {
warning:           ^

Which was fall out from 130a1df.

Fixes #99955

Fixes a warning:

warning: llvm-wrapper/RustWrapper.cpp:159:11: warning: enumeration values 'AllocatedPointer' and 'AllocAlign' not handled in switch [-Wswitch]
warning:   switch (Kind) {
warning:           ^

Which was fall out from 130a1df.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 30, 2022
@rust-highfive
Copy link
Collaborator

r? @cuviper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 30, 2022
@est31 est31 marked this pull request as ready for review July 30, 2022 16:55
@cuviper
Copy link
Member

cuviper commented Jul 30, 2022

Looks good, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 30, 2022

📌 Commit eca274a has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2022
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#99650 (Support `x --keep-stage 0 check`)
 - rust-lang#99873 (rustdoc: align invalid-html-tags lint with commonmark spec)
 - rust-lang#99889 (Remove `parent_pat` from `TopInfo`)
 - rust-lang#99890 (Do not allow bad projection term to leak into the type checker)
 - rust-lang#99937 (Reset directory iteration in remove_dir_all)
 - rust-lang#99950 (Remove more Clean trait implementations)
 - rust-lang#99956 (Also gate AllocatedPointer and AllocAlign definitions by LLVM_VERSION_GE)
 - rust-lang#99962 (Discover channel for LLVM download)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b9ad36c into rust-lang:master Jul 30, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning: enumeration values 'AllocatedPointer' and 'AllocAlign' not handled in switch
5 participants