Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rkyv support #110

Merged
merged 5 commits into from
Jan 19, 2023
Merged

add rkyv support #110

merged 5 commits into from
Jan 19, 2023

Conversation

zyansheep
Copy link
Contributor

For some reason github closed the old PR while I was trying to merge master into the old pr.
Should've used rebase!

@zyansheep zyansheep mentioned this pull request Aug 16, 2022
Merged
@zyansheep
Copy link
Contributor Author

@cuviper Any way this can get merged? dimforge/nalgebra#1128 is blocking on this...

cuviper
cuviper requested changes Oct 20, 2022
View reviewed changes
.github/workflows/ci.yaml Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
ci/test_full.sh Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@zyansheep
Copy link
Contributor Author

@cuviper I have made the changes requested :)

cuviper
cuviper reviewed Nov 2, 2022
View reviewed changes
src/lib.rs Show resolved Hide resolved
cuviper
cuviper reviewed Nov 2, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@sebcrozet
Copy link

Is there any update on this PR? I merged dimforge/nalgebra#1128 without Complex support in the mean time.

@cuviper
Copy link
Member

cuviper commented Jan 19, 2023

OK, let's go!

bors r+

bors bot added a commit that referenced this pull request Jan 19, 2023
@bors @zyansheep
Merge #110
f7b4ad2 
110: add rkyv support r=cuviper a=zyansheep

For some reason github closed the old PR while I was trying to merge master into the old pr.
Should've used rebase!

Co-authored-by: zyansheep <zyansheep@protonmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 19, 2023

Build failed:

@cuviper
Copy link
Member

cuviper commented Jan 19, 2023

Bah, libm published new versions with a higher MSRV. I'll deal with that...

@cuviper
Copy link
Member

cuviper commented Jan 19, 2023

bors r+

bors bot added a commit that referenced this pull request Jan 19, 2023
@bors @zyansheep @cuviper
Merge #110
19c1424 
110: add rkyv support r=cuviper a=zyansheep

For some reason github closed the old PR while I was trying to merge master into the old pr.
Should've used rebase!

Co-authored-by: zyansheep <zyansheep@protonmail.com>
Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 19, 2023

Canceled.

@cuviper
Copy link
Member

cuviper commented Jan 19, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 19, 2023

Build succeeded:

@bors bors bot merged commit d33abcb into rust-num:master Jan 19, 2023
@cuviper
Copy link
Member

cuviper commented Jan 19, 2023

This is published in 0.4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zyansheep @sebcrozet @cuviper