Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open source project to add message queue direction -RobustMQ #1803

Merged
merged 10 commits into from
Sep 15, 2024

Conversation

socutes
Copy link

@socutes socutes commented Sep 11, 2024

@palfrey PTAL, Thanks. It looks like it meets the project inclusion criteria. There are already 51 stars, and we will continue to work hard and hope that more people can see our work.
https://github.com/robustmq/robustmq

dyz1990/sevenz-rust library no longer exists and was removed to resolve a build failure

#1782

@socutes
Copy link
Author

socutes commented Sep 12, 2024

@palfrey Workflow needs to be approved, please have a look, thank you.

@socutes
Copy link
Author

socutes commented Sep 12, 2024

@palfrey Please have a look at the build error log, it seems that is deleted https://github.com/dyz1990/sevenz-rust, this project should be how to deal with this situation.

@socutes
Copy link
Author

socutes commented Sep 13, 2024

dyz1990/sevenz-rust library no longer exists and was removed to resolve a build failure

@socutes
Copy link
Author

socutes commented Sep 14, 2024

@palfrey Error: ErrorMessage { msg: "Not high enough metrics (None stars < 50, and None cargo downloads < 2000): 7z" }

Why do you get this error? It looks like we met the criteria.

image

README.md Outdated
@@ -1062,7 +1067,6 @@ See also [About Rust’s Machine Learning Community](https://medium.com/@autumn_
### Compression

* [7z](https://7-zip.org/7z.html)
* [dyz1990/sevenz-rust](https://github.com/dyz1990/sevenz-rust) [[sevenz-rust](https://crates.io/crates/sevenz-rust)] - A 7z decompressor/compressor written in pure rust. [![Rust](https://github.com/dyz1990/sevenz-rust/workflows/Rust/badge.svg?branch=main)](https://github.com/dyz1990/sevenz-rust/actions)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed (keeping the crate link, dropping the repo) in main, please merge that.

@palfrey
Copy link
Collaborator

palfrey commented Sep 14, 2024

@palfrey Error: ErrorMessage { msg: "Not high enough metrics (None stars < 50, and None cargo downloads < 2000): 7z" }

Why do you get this error? It looks like we met the criteria.

image

Note the lines above

[2024-09-14T00:03:30Z WARN  awesome_rust] No valid github link
[2024-09-14T00:03:30Z WARN  awesome_rust] No valid crates link

It's not picking up the Github link for some reason, hence the wrong count. Also note, stars as None, not 0 :)

It looks like it should match the regex, and there's the Downloading GitHub stars line before that, so I think it's picking it up. Very weird. Not quite sure TBH, will have a look at some point.

@palfrey
Copy link
Collaborator

palfrey commented Sep 14, 2024

Solved it :) The "no valid github/crates link" were due to the 7z change, not robustmq. main branch now has better debug for that.

@socutes socutes closed this Sep 15, 2024
@socutes socutes reopened this Sep 15, 2024
@socutes
Copy link
Author

socutes commented Sep 15, 2024

Solved it :) The "no valid github/crates link" were due to the 7z change, not robustmq. main branch now has better debug for that.

@palfrey Thanks for your time, I'm done dealing with code conflicts. I think we'll be all right this time.

@palfrey palfrey merged commit aac6252 into rust-unofficial:main Sep 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants