Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split result type into Ok and Err class - Updated #27

Merged
merged 20 commits into from
Apr 15, 2020
Merged

Split result type into Ok and Err class - Updated #27

merged 20 commits into from
Apr 15, 2020

Commits on Apr 15, 2020

  1. Split Result type into Ok and Err class

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    613c4c2 View commit details
    Browse the repository at this point in the history

  2. Update the README.rst

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    0f1b32a View commit details
    Browse the repository at this point in the history

  3. Use isinstance instead of .is_ok() in the typetest

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    79164b8 View commit details
    Browse the repository at this point in the history

  4. Add test case to get 100% coverage

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    b8432ca View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary use of pytest.paramterize

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    8818ae1 View commit details
    Browse the repository at this point in the history

  6. Add a migration guide from 0.5 to 0.6

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    0cf2b70 View commit details
    Browse the repository at this point in the history

  7. Fix some small mistakes in the README

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    82d3541 View commit details
    Browse the repository at this point in the history

  8. Add a ResultType abstract base class to use `isinstace(res, ResultT… 

    …ype)`
    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    314bafb View commit details
    Browse the repository at this point in the history

  9. Added a README example of using ResultType

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    4d8722c View commit details
    Browse the repository at this point in the history

  10. Do not use an abstract base class for Ok and Err

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    0570bcb View commit details
    Browse the repository at this point in the history

  11. Rename Result_ to OkErr

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    52090a0 View commit details
    Browse the repository at this point in the history

  12. Add MyPy link to README and fix inline code

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    b0d58d4 View commit details
    Browse the repository at this point in the history

  13. Remove forgotten Result_ type in MIGRATING.md

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    6e8f431 View commit details
    Browse the repository at this point in the history

  14. Update README with PR feedback

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    8f1e86d View commit details
    Browse the repository at this point in the history

  15. Remove incorrect underscore in parameter name

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    da8de1f View commit details
    Browse the repository at this point in the history

  16. Change argument identation to 1 level instead of 2

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    c639782 View commit details
    Browse the repository at this point in the history

  17. Change return type of Ok.expect_err to NoReturn

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    505146c View commit details
    Browse the repository at this point in the history

  18. Fix incorrect docstring on map_err method

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    a8c2753 View commit details
    Browse the repository at this point in the history

  19. Narrow down types in the typetests

    @Jasonoro @dbrgn
    Jasonoro authored and dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    36434bb View commit details
    Browse the repository at this point in the history

  20. Fix failing tests

    @dbrgn
    dbrgn committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    39cbf7e View commit details
    Browse the repository at this point in the history