Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change left over Result to OkErr in the migrating guide #30

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Change left over Result to OkErr in the migrating guide #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MIGRATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ res2 = Err('nay')
```

2\. Result is now a Union type between `Ok[T]` and `Err[E]`. As such, you cannot use `isinstance(res, Result)` anymore.
These should be replaced by `isinstance(res, Result)`. As an example, the following code:
These should be replaced by `isinstance(res, OkErr)`. As an example, the following code:

```python
from result import Ok, Result
Expand Down