Remove getset dependency #358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance this could be acted on? It'd remove an annoying advisory from the dependency tree of |
|
@LukeMathWalker Yeah it has some lint issues that need to be fixed. If the submitter doesn't rectify those shortly I'll close this and get it done myself. On a side note, I'm not a fan of using RUSTSEC to report unmaintained crates, unless they themselves have security issues. I haven't dug into |
|
Superseded by #379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getsetis pretty old and pulls in a bit of dependencies, including syn v1 (there is a PR to update to syn v2, but it has not been acted on for a few months). Since it is sparsely used, I simply usedcargo expandand copied the relevant code.This should not affect anything other than some reduced dependencies.