Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #2391 - Remove sqlx features from db_pools #2392

Closed
wants to merge 3 commits into from

Conversation

aadityadhruv
Copy link

By removing sqlx features from the crate itself, the choice is put upon the user, which lets them choose between rustls and native-tls.

@SergioBenitez
Copy link
Member

Remove the feature means that sqlx doesn't compile. Not removing the feature means we have this issue. Adding a separate feature to enable native_tls instead means we can't compile the crate with --all-features. I don't see a solution here that is good. The problems, in my opinion, are in sqlx (for how they implemented features, which they've fixed in 0.7) and rustls/webpki, for the initial source of the problem with resolving IP addresses.

I am unfortunately inclined to suggest that we wait for a fix upstream. Unless there's a solution I'm missing that:

  1. Doesn't require everyone to depend on sqlx for use db_pools with sqlx.
  2. Allowing use to build contrib with --all-features.
  3. Allows selecting either rustls or native-tls

@aadityadhruv
Copy link
Author

That sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants