Construct rocket_param_ idents from the function arguments
#778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the route string.
jebrosen
commented
Sep 25, 2018
| None => { | ||
| self.missing_declared_err(ecx, param.inner()); | ||
| continue; | ||
| } | ||
| }; | ||
|
|
||
| let ty = strip_ty_lifetimes(arg.ty.clone()); | ||
| let ident = arg.ident().expect("function argument ident").prepend(PARAM_PREFIX); |
There was a problem hiding this comment.
Is it correct to expect this? I didn't look too thoroughly, but I think only PatKind::Ident is valid for FromParam guards, in practice.
There was a problem hiding this comment.
Yes; the find_input() method only returns Some if ident() here would return Some. Since we bailed on the None case above, this is safe.
|
Merged in eb1ce54. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of the route string. Should fix #635.
The included test fails in current v0.3 but passes with this change. The test might also be useful in the master branch, but the bug may no longer be present once
#[route]is re-implemented for #693.