Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to use #[get] inside of macros #896

Closed
wants to merge 2 commits into from
Closed

Allow users to use #[get] inside of macros #896

wants to merge 2 commits into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 22, 2019

No description provided.

@jebrosen
Copy link
Collaborator

I see this as a strict win (not compiling -> compiling with an imperfect diagnostic).

I think the test fits better in core/codegen/tests/expansion.rs that came about from the last nested-macro bug (#635).

@SergioBenitez
Copy link
Member

This is great. Thanks, @oli-obk, @jebrosen. Merged in c86f431.

@SergioBenitez SergioBenitez added the pr: merged This pull request was merged manually. label Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jebrosen jebrosen jebrosen approved these changes

Assignees
No one assigned
Labels
pr: merged This pull request was merged manually.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oli-obk @jebrosen @SergioBenitez