27.1.22 fix(html): Remove role=menubar:

- `src/layouts/includes/mapjs-widget-controls.html`: Remove `role="menubar"` from `mapjs_control` <div>. - Update doc examples.
s6mike · Dec 27, 2023 · 34b3fa3 · 34b3fa3
1 parent acf868f
commit 34b3fa3
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -6,6 +6,11 @@
   - Add note about linking/using templates (html and latex) with pandoc.
   - Add references to argmap specs spreadsheet?
 
+## argmap 27.1.22
+
+- `src/layouts/includes/mapjs-widget-controls.html`: Remove `role="menubar"` from `mapjs_control` <div>.
+  - Update doc examples.
+
 ## argmap 27.1.21
 
 - `makefile`: Replace `mapjs/node_modules` references with `mapjs/node_modules/.package-lock.json` since this should represent the whole folder and its timestamp should be more accurate reflection of relative updates.

diff --git a/docs/example-updated.html b/docs/example-updated.html
@@ -23,7 +23,7 @@ <h1 class="title">An Example</h1>
 
         <h2>Example Argument map</h2>
         <div class="mapjs-app" tabindex="-1">
-          <div id="menubar-mapjs-" class="menubar-mapjs" role="menubar">
+          <div id="menubar-mapjs-" class="menubar-mapjs">
             <section>
               <div class="toolbar-mapjs-main" role="toolbar" aria-label="Node editing">
                 <input type="button" class="saveMap" value="Save" aria-label="Save" />

diff --git a/mapjs/docs/legacy-mapjs-example-map.html b/mapjs/docs/legacy-mapjs-example-map.html
@@ -23,7 +23,7 @@ <h1 class="title">legacy-mapjs-example-map</h1>
 
               <h2>Example Argument map</h2>
               <div class="mapjs-app" tabindex="-1">
-                <div id="menubar-mapjs-1" class="menubar-mapjs" role="menubar">
+                <div id="menubar-mapjs-1" class="menubar-mapjs">
                   <section>
                     <div class="toolbar-mapjs-main" role="toolbar" aria-label="Node editing">
                       <input type="button" class="saveMap" value="Save" aria-label="Save" />

diff --git a/src/layouts/includes/mapjs-widget-controls.html b/src/layouts/includes/mapjs-widget-controls.html
@@ -1,6 +1,6 @@
 $-- TODO: Class attributes should be kebab-case.
 $--   QUESTION: However, want to include data for function to be called, so maybe use data-function attributes to provide this info?
-<div id="${mapjs_control.id-prefix}${MAP_INSTANCE_ID}" class="${mapjs_control.class}" role="menubar">
+<div id="${mapjs_control.id-prefix}${MAP_INSTANCE_ID}" class="${mapjs_control.class}">
   <section>
     <div class="${toolbar_main.class}" role="toolbar" aria-label="Node editing">
       <input type="button" class="saveMap" value="Save" aria-label="Save" />