fix: list items do not get reset when InboxRecyclerView's size is cha…

…nged
saket · Sep 12, 2019 · 7654e48 · 7654e48
1 parent c211831
commit 7654e48
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/...clerview/src/main/java/me/saket/inboxrecyclerview/animation/PageLocationChangeDetector.kt b/...clerview/src/main/java/me/saket/inboxrecyclerview/animation/PageLocationChangeDetector.kt
@@ -9,7 +9,10 @@ internal class PageLocationChangeDetector(
   private val changeListener: () -> Unit
 ) : ViewTreeObserver.OnPreDrawListener, ViewTreeObserver.OnGlobalLayoutListener {
 
+  private var lastTranslationX = 0F
   private var lastTranslationY = 0F
+  private var lastWidth = 0
+  private var lastHeight = 0
   private var lastClippedDimens = Rect()
   private var lastState = page.currentState
 
@@ -24,15 +27,20 @@ internal class PageLocationChangeDetector(
   }
 
   private fun dispatchCallbackIfNeeded() {
-    val moved = lastTranslationY != page.translationY
-    val dimensionsChanged = lastClippedDimens != page.clippedDimens
+    val moved = lastTranslationX != page.translationX || lastTranslationY != page.translationY
     val stateChanged = lastState != page.currentState
+    val dimensionsChanged = lastWidth != page.width
+        || lastHeight != page.height
+        || lastClippedDimens != page.clippedDimens
 
     if (moved || dimensionsChanged || stateChanged) {
       changeListener()
     }
 
+    lastTranslationX = page.translationX
     lastTranslationY = page.translationY
+    lastWidth = page.width
+    lastHeight = page.height
     lastClippedDimens = page.clippedDimens
     lastState = page.currentState
   }

diff --git a/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/page/BaseExpandablePageLayout.kt b/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/page/BaseExpandablePageLayout.kt
@@ -23,6 +23,7 @@ abstract class BaseExpandablePageLayout @JvmOverloads constructor(
 ) : RelativeLayout(context, attrs) {
 
   /** The visible portion of this layout. */
+  // TODO: This creates a new Rect internally everytime. Optimize this.
   val clippedDimens: Rect
     get() = clipBounds