Skip to content

Commit

Permalink
schema: improve wording in interfaces description field
Browse files Browse the repository at this point in the history
Thanks to @anoopcs9 for pointing out some potentially confusing wording
in the previous patches adding interfaces options include_pattern &
exclude_pattern. Change 'system interfaces' to 'network interfaces'.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
  • Loading branch information
phlogistonjohn authored and mergify[bot] committed Mar 4, 2024
1 parent 522df0c commit bbb1801
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions sambacc/schema/conf-v0.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,11 @@
"properties": {
"include_pattern": {
"type": "string",
"description": "A regular expression that must match for a system interface\nto be included in the AD DC interfaces list.\n"
"description": "A regular expression that must match for a network interface\nto be included in the AD DC interfaces list.\n"
},
"exclude_pattern": {
"type": "string",
"description": "A regular expression that must not match for a system interface\nto be included in the AD DC interfaces list.\n"
"description": "A regular expression that must not match for a network interface\nto be included in the AD DC interfaces list.\n"
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions sambacc/schema/conf-v0.schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -255,12 +255,12 @@ properties:
include_pattern:
type: string
description: |
A regular expression that must match for a system interface
A regular expression that must match for a network interface
to be included in the AD DC interfaces list.
exclude_pattern:
type: string
description: |
A regular expression that must not match for a system interface
A regular expression that must not match for a network interface
to be included in the AD DC interfaces list.
required:
- realm
Expand Down
4 changes: 2 additions & 2 deletions sambacc/schema/conf_v0_schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -281,15 +281,15 @@
"type": "string",
"description": (
"A regular expression that must match for"
" a system interface\nto be included in"
" a network interface\nto be included in"
" the AD DC interfaces list.\n"
),
},
"exclude_pattern": {
"type": "string",
"description": (
"A regular expression that must not match"
" for a system interface\nto be included"
" for a network interface\nto be included"
" in the AD DC interfaces list.\n"
),
},
Expand Down

0 comments on commit bbb1801

Please sign in to comment.