Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple support for ctdb public addrs #133

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Add simple support for ctdb public addrs #133

merged 3 commits into from
Aug 26, 2024

Conversation

phlogistonjohn
Copy link
Collaborator

Allow sambacc to set up the public_addresses file for ctdb and enable the required event script for basic ip failover.

@phlogistonjohn phlogistonjohn marked this pull request as ready for review August 22, 2024 14:09
synarete
synarete approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phlogistonjohn
Copy link
Collaborator Author

@Mergifyio rebase

@phlogistonjohn
sambacc: add config placeholder for ctdb public address config
344877b 
Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
sambacc: add public addresses support to ctdb module
cbf9702 
Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
commands: pass instance config to ctdb etc setup
7ad5000 
Pass instance config to ctdb etc setup that will allow the use of public
addresses configuration.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@mergify Mergify
Copy link

mergify bot commented Aug 22, 2024

rebase

✅ Branch has been successfully rebased

@phlogistonjohn phlogistonjohn mentioned this pull request Aug 23, 2024
Merged
14 tasks
@phlogistonjohn
Copy link
Collaborator Author

@anoopcs9 PTAL.

avanthakkar
avanthakkar approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

xhernandez
xhernandez approved these changes Aug 26, 2024
View reviewed changes
sambacc/ctdb.py Show resolved Hide resolved
obnoxxx
obnoxxx approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't claim to have understood every little bit of python code in this, but what I see looks very reasonable to me.

LGTM.

@mergify mergify bot merged commit 02b6b18 into samba-in-kubernetes:master Aug 26, 2024
9 checks passed
anoopcs9
anoopcs9 reviewed Aug 27, 2024
View reviewed changes
sambacc/ctdb.py Show resolved Hide resolved
sambacc/ctdb.py Show resolved Hide resolved
@anoopcs9 anoopcs9 mentioned this pull request Aug 28, 2024
Merged
@phlogistonjohn phlogistonjohn deleted the jjm-ctdb-public-addrs branch August 28, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoopcs9 anoopcs9 anoopcs9 left review comments

@xhernandez xhernandez xhernandez approved these changes

@obnoxxx obnoxxx obnoxxx approved these changes

@synarete synarete synarete approved these changes

@avanthakkar avanthakkar avanthakkar approved these changes

Assignees
No one assigned
Labels
priority-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@phlogistonjohn @xhernandez @anoopcs9 @obnoxxx @synarete @avanthakkar