Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctdb: Leave CTDB log levels at their original defaults #139

Merged

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Oct 4, 2024

There is too much information with the log level explicitily set to DEBUG for ctdbd flooding the log file destination. Similarly script log level option might also spit out more when set to DEBUG. Instead of removing the options altogether we change the sambacc defaults from DEBUG to NOTCE and ERROR respectively for log level and script log level options as specified in man ctdb.conf(5).

@anoopcs9 anoopcs9 force-pushed the ctdb-default-log-levels branch 2 times, most recently from 2dcbcfe to 3dc1382 Compare October 4, 2024 09:44
There is too much information with the 'log level' explicitily set to
DEBUG for ctdbd flooding the log file destination. Similarly 'script
log level' option might also spit out more when set to DEBUG. Instead
of removing the options altogether we change the sambacc defaults from
DEBUG to NOTCE and ERROR respectively for 'log level' and 'script log
level' options as specified in man ctdb.conf(5).

ref: https://ctdb.samba.org/manpages/ctdb.conf.5.html

Signed-off-by: Anoop C S <anoopcs@samba.org>
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Copy link
Collaborator

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 282b0b9 into samba-in-kubernetes:master Oct 4, 2024
9 checks passed
@anoopcs9 anoopcs9 deleted the ctdb-default-log-levels branch October 4, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants