Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass global options to provision and join calls #45

Closed
wants to merge 8 commits into from
Closed

Pass global options to provision and join calls #45

wants to merge 8 commits into from

Conversation

phlogistonjohn
Copy link
Collaborator

@phlogistonjohn phlogistonjohn commented Jun 3, 2022 •
edited
Loading

Support taking global options defined in the configuration and passing them onto the samba-tools commands that will generate smb.conf.

Fixes: #43

@phlogistonjohn
sambacc: add options argument to addc provision function
f1b3cce 
This will allow setting of smb.conf options at provision time.


Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
sambacc: add options argument to addc join function
0360bf6 
Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
tests: add unit test cases for addc functions
1ce9555 
Apparently, I'm lazy and had not done it before.


Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
commands: pass global options to provision and join calls
9770a47 
This allows the customization of samba DC configuration beyond
the core parameters needed for domain provision or join.


Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
Copy link
Collaborator Author

Unit tests are fine, but testing it practically I don't see the option making it into smb.conf, even though I've confirmed were passing the --option=foo=bar CLI arguments. I'm going to leave this as a draft until I do some more practical tests and understand what samba-tool expects the options to be.

@phlogistonjohn
xxx: sambacc/addc.py: use smb.conf file
f3c15c2 
Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
xxx: tests
c15615b 
Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
xxx: assert conf file not created
d205334 
Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
xxx: need workgroup and server role present
3f8a725 
Signed-off-by: John Mulligan <jmulligan@redhat.com>
@anoopcs9 anoopcs9 mentioned this pull request Jun 17, 2022
Closed
@phlogistonjohn
Copy link
Collaborator Author

Getting the exact combination of CLI and smb.conf to work is proving tricky. I haven't given up on this tho.

obnoxxx
obnoxxx requested changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase on current master and resolve conflicts.

@phlogistonjohn
Copy link
Collaborator Author

I can, unfortunately the code does not function as intended. I haven't had time to follow up on this as I think we'll need to better understand / discuss the behavior of samba-tool with regards to default options. JFYI

@phlogistonjohn
Copy link
Collaborator Author

Closed because this approach just won't work and it's been over 6 months outstanding. There's still an open issue to work on this which is not being closed.

@phlogistonjohn phlogistonjohn mentioned this pull request Aug 11, 2023
Merged
@phlogistonjohn phlogistonjohn deleted the jjm-addc-globals branch August 28, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obnoxxx obnoxxx obnoxxx requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuring globals does not appear to work
2 participants
@phlogistonjohn @obnoxxx