Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sambacc: complete type annotations #47

Merged
merged 15 commits into from
Nov 16, 2022
Merged

sambacc: complete type annotations #47

merged 15 commits into from
Nov 16, 2022

Commits on Nov 8, 2022

  1. sambacc: complete type annotations for config.py 

    Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    17ac18a View commit details
    Browse the repository at this point in the history

  2. sambacc: complete type annotations for ctdb.py 

    Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    c6490c2 View commit details
    Browse the repository at this point in the history

  3. sambacc: complete type annotations for inotify_waiter.py 

    Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    f46400a View commit details
    Browse the repository at this point in the history

  4. sambacc: complete type annotations for jfile.py 

    Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    00f38f4 View commit details
    Browse the repository at this point in the history

  5. sambacc: complete type annotations for join.py 

    Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    4241501 View commit details
    Browse the repository at this point in the history

  6. sambacc: complete type annotations for netcmd_loader.py 

    Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    596a3a3 View commit details
    Browse the repository at this point in the history

  7. sambacc: complete type annotations for nsswitch_loader.py 

    Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    e62ff4e View commit details
    Browse the repository at this point in the history

  8. sambacc: complete type annotations for passdb_loader.py 

    Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    39df468 View commit details
    Browse the repository at this point in the history

  9. sambacc: complete type annotations for passwd_loader.py 

    Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    82df046 View commit details
    Browse the repository at this point in the history

  10. sambacc: complete type annotations for permissions.py 

    Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    2f304f6 View commit details
    Browse the repository at this point in the history

  11. sambacc: complete type annotations for samba_cmds.py 

    Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    aa953d7 View commit details
    Browse the repository at this point in the history

  12. sambacc: complete type annotations for simple_waiter.py 

    Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    3ee1dbe View commit details
    Browse the repository at this point in the history

  13. sambacc: complete type annotations for container_dns.py 

    This includes a small change to the signature of the watch function
to only accept a print_func callable and never none. This required
a small update to the test code. The real code always passed a function
and the ability to pass none never really could have worked right
anyway.


Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    deb7cae View commit details
    Browse the repository at this point in the history

  14. pyproject: require type annotations for sambacc function defs 

    The sambacc dir is basically a library and we want to ensure high
quality and good documentation so configure mypy to require
type annotations on functions defined in sambacc.
The sambacc.commands on the other hand are mean to be only
run as part of our CLI tools so we'll be a bit less strict there.


Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    6aec8fd View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Merge branch 'master' into jjm-even-more-typing

    @phlogistonjohn
    phlogistonjohn authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    1ce43ee View commit details
    Browse the repository at this point in the history