Check commit messages with gitlint #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlogistonjohn
force-pushed
the
jjm-gitlint
branch
from
8dbb825
to
4a757fc
Compare
|
🎉 All dependencies have been resolved ! |
|
This pull request now has conflicts with the target branch. Please resolve these conflicts and force push the updated branch. |
phlogistonjohn
force-pushed
the
jjm-gitlint
branch
from
4a757fc
to
d78127c
Compare
|
This should be good to be reviewed minus the intentional failing commit. Once I get at least one vague thumbs up I'll remove the bad commit and take it out of draft. |
synarete
previously approved these changes
Apr 18, 2023
phlogistonjohn
force-pushed
the
jjm-gitlint
branch
from
d78127c
to
fbb44a3
Compare
|
@Mergifyio rebase |
❌ Unable to rebase: user
|
The new gitlint tox environment is not run by default, it can be run manually or by CI in order to check that commit messages meet some basic quality criteria. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Add a simple gitlint configuration file. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn
force-pushed
the
jjm-gitlint
branch
from
fbb44a3
to
07d8687
Compare
anoopcs9
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a tox environment for checking commits with gitlint. Add a CI job for checking
Depends on: #74