Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smb2.session.reauth4 to flapping list for XFS and CephFS(kclient) #87

Merged

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Jul 5, 2024

With recent changes to smb.conf, smb2.session.reauth4 is expected to fail on XFS and CephFS kclient method. You can find more details from samba-in-kubernetes/sit-environment#109 (comment).

Also remember that this is not a problem with CephFS vfs approach but our clone of selftest mechanism currently lacks the ability to consider flapping lists based on variants for a particular backend.

@spuiuk
Copy link
Collaborator

spuiuk commented Jul 5, 2024

We could use "cephfs-vfs"(or any other variation) as a new filesystem.
The cost is simply a new flapping.cephfs-vfs list in the selftest directory which needs to be maintained. Since this doesn't change all that much, it isn't all that difficult to maintain. I expect to see more of this in the future and therefore should be fixed properly now.

To do this.

  1. Add a new patch to copy flapping.ceph list to a new flapping.ceph-vfs list. This patch has to go in before we modify the file to add smb2.session.reauth4 to it.
    Other patches from this PR apply.

We then
2) patch sit-environment to user "filesystem-variant" when setting the filesystem in testinfo.yml

@anoopcs9 anoopcs9 force-pushed the amend-flapping-for-reauth4 branch from a040148 to 2c39fac Compare July 5, 2024 20:59
@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented Jul 5, 2024

  1. Add a new patch to copy flapping.ceph list to a new flapping.ceph-vfs list. This patch has to go in before we modify the file to add smb2.session.reauth4 to it.
    Other patches from this PR apply.

#88 created.

@spuiuk spuiuk self-requested a review July 8, 2024 11:59
Copy link
Collaborator

@spuiuk spuiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

With recent changes to smb.conf[1] smb2.session.reauth4 is expected to
fail on XFS. Refer [1] for more deails.

[1] samba-in-kubernetes/sit-environment#109

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
With recent changes to smb.conf[1], smb2.session.reauth4 is expected to
fail on CephFS kclient method. Refer [1] for more details.

Also remember that this is not a problem with CephFS vfs approach but
our clone of selftest mechanism currently lacks the ability to consider
flapping lists based on variants for a particular backend.

[1] samba-in-kubernetes/sit-environment#109

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 anoopcs9 force-pushed the amend-flapping-for-reauth4 branch from feac2b4 to 5a4218c Compare July 8, 2024 12:25
@anoopcs9 anoopcs9 merged commit 3a0ab60 into samba-in-kubernetes:main Jul 8, 2024
7 of 10 checks passed
@anoopcs9 anoopcs9 deleted the amend-flapping-for-reauth4 branch July 8, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants