Add epsilon after precision-factor-multiplication #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janfb
reviewed
Aug 24, 2022
| @@ -81,7 +81,7 @@ def __init__( | |||
| raise NotImplementedError | |||
|
|
|||
| # Constant for numerical stability. | |||
| self._epsilon = 1e-2 | |||
| self._epsilon = 1e-4 | |||
There was a problem hiding this comment.
we should add a test in sbi to make sure this really fixes the issue.
There was a problem hiding this comment.
Agreed, I'll create an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue of SNPE-C.
The change is that we apply the epsilon addition after having multiplied the precision factors. I.e., instead of
we now do
This fixes SNPE-C on the toy example posted in the issue posted above.
I also decreased the magnitude of
epsbecause previously, it was essentially squared through the(L+eps) (L+eps)^Toperation.