Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change license to Apache 2.0 #28

Merged
merged 1 commit into from
Aug 20, 2024
Merged

change license to Apache 2.0 #28

merged 1 commit into from
Aug 20, 2024

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Apr 2, 2024

In line with the planned license change in sbi, I suggest to change the license of pyknos to Apache 2.0 as well. Please see sbi-dev/sbi#997 for details.

Please indicate your approval of this change by approving this PR or by commenting below.

Thanks 🙏

Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jan, I approve of changing the license of the pyknos repo to Apache 2.0

@janfb
Copy link
Contributor Author

janfb commented Apr 2, 2024

@conormdurkan we need your approval as well because it's all based on your MDN implementation :)

@janfb
Copy link
Contributor Author

janfb commented Apr 2, 2024

@harry-fuyu we kindly ask for your approval because you contributed during your internship with us.

@harry-fuyu
Copy link
Contributor

harry-fuyu commented Apr 2, 2024 via email

@janfb
Copy link
Contributor Author

janfb commented Apr 2, 2024 via email

@harry-fuyu
Copy link
Contributor

harry-fuyu commented Apr 2, 2024 via email

@michaeldeistler
Copy link
Contributor

@alvorithm @jan-matthis @conormdurkan please have a look and approve the pull request if you are fine with the change.

@alvorithm
Copy link

While in general I remain a proponent of strong copyleft licenses, I also wholeheartedly share the goal to make pyknos and sbi approachable for a wider community of users and developers. Acknowledging compelling arguments made by fellow team members, I am now keen to find out in practice to what extent adopting weaker copyleft might help to that end.

Hence, I approve relicensing pyknos under the Apache 2.0 license.

@michaeldeistler
Copy link
Contributor

@conormdurkan could you please have a look and approve the pull request if you are fine with the change.

@janfb
Copy link
Contributor Author

janfb commented Aug 19, 2024

Given that @conormdurkan agreed to the re-licensing of the code in sbi, and the code used here is actually the same code, I would opt for merging this pull request soon.

@michaeldeistler
Copy link
Contributor

I would be fine with merging too.

@janfb janfb merged commit 3e4ec5d into main Aug 20, 2024
1 check failed
@janfb janfb deleted the change-license-to-apache2.0 branch August 20, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants