Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java time objects as valid BuildInfoKey values #178

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

nMoncho
Copy link

@nMoncho nMoncho commented Nov 2, 2021

As part of our project we tag the release date of each of our components, but we'd like to operate on Java Time classes. This PR adds both java.time.LocalDate and java.time.Instant.
Due to backwards compatibility I decided not to modify the behavior of BuildInfoOption.BuildTime

@nMoncho
Copy link
Author

nMoncho commented Jan 21, 2022

hey @eed3si9n, would this PR be interesting to the project?

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
sorry about the delayed review

@eed3si9n
Copy link
Member

CI is still pointing at Travis so it might not succeed, but I'll try to run the tests locally and get it to merge this weekend.

@eed3si9n eed3si9n closed this Feb 16, 2022
@eed3si9n eed3si9n reopened this Feb 16, 2022
@eed3si9n eed3si9n merged commit 31ae439 into sbt:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants