-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sbt-sonatype bundle release to speed up publishing #59
Conversation
hell |
8a10f3a
to
1725b04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution! I am very excited to try out bundle releases :D
@@ -89,7 +89,7 @@ object CiReleasePlugin extends AutoPlugin { | |||
} else { | |||
println("Tag push detected, publishing a stable release") | |||
sys.env.getOrElse("CI_RELEASE", "+publishSigned") :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be necessary as well? I can't tell from the sbt-sonatype readme, but my intuition is that the speedups are gained from not running publishSigned
(which is usually bottleneck).
sys.env.getOrElse("CI_RELEASE", "+publishSigned") :: | |
sys.env.getOrElse("CI_RELEASE", "+publishLocalSigned") :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reading was that publishSigned
goes into an archive thing locally if you set publishTo := sonatypePublishToBundle.value
and then it's all shipped atomically when you do sonatypeBundleRelease
. Maybe @xerial can clarify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank makes sense, let's give it a try and see it how fares!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it failed with
[error] java.io.IOException: Supplied file /home/travis/build/olafurpg/sbt-ci-release/target/sonatype-staging/sbt-ci-release-1.3.0 is a not an existing directory!
The local directory was
info] published sbt-ci-release to /home/travis/build/olafurpg/sbt-ci-release/target/sonatype-staging/plugin-1.3.0/com/geirsson/sbt-ci-release_2.12_1.0/1.3.0/sbt-ci-release-1.3.0-javadoc.jar.asc
It looks like sonatypePublishToBundle
is using the project's id
and sonatypeBundleRelease
is using the moduleName
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-\
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With publishTo := sonatypePublishToBundle.value setting, publishSigned task will create a local staging folder.
It's a bit confusing, but publishLocalSigned task is for storing artifacts into ~/.ivy2/ folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -89,7 +89,7 @@ object CiReleasePlugin extends AutoPlugin { | |||
} else { | |||
println("Tag push detected, publishing a stable release") | |||
sys.env.getOrElse("CI_RELEASE", "+publishSigned") :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank makes sense, let's give it a try and see it how fares!
There's a new version already. Investigating. |
This resolves #58 in principle but despite changing the sbt-sonatype version to 3.4
libraryDependencies
still shows 2.6 and thesonatypePublishToBundle
key is not found. I am completely baffled. Any ideas?Also unclear how to test this.