-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CircleCI support #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution!
@@ -25,29 +25,34 @@ object CiReleasePlugin extends AutoPlugin { | |||
override def requires = | |||
JvmPlugin && SbtPgp && DynVerPlugin && GitPlugin && Sonatype | |||
|
|||
def isTravisSecure: Boolean = | |||
def isSecure: Boolean = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the old Travis methods, forward them to the new methods and add @deprecated
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olafurpg good idea. Done! For the since field of deprecated
I went with the next incremental release number from the last release. If you prefer a different next release number or a date instead let me know. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you!
I’ll try push a new release tomorrow once I’m at my laptop
Summary
Resources