Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CircleCI support #93

Merged
merged 2 commits into from
Dec 28, 2019
Merged

Added CircleCI support #93

merged 2 commits into from
Dec 28, 2019

Conversation

softinio
Copy link
Contributor

@softinio softinio commented Dec 28, 2019

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

@@ -25,29 +25,34 @@ object CiReleasePlugin extends AutoPlugin {
override def requires =
JvmPlugin && SbtPgp && DynVerPlugin && GitPlugin && Sonatype

def isTravisSecure: Boolean =
def isSecure: Boolean =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the old Travis methods, forward them to the new methods and add @deprecated?

Copy link
Contributor Author

@softinio softinio Dec 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olafurpg good idea. Done! For the since field of deprecated I went with the next incremental release number from the last release. If you prefer a different next release number or a date instead let me know. Thanks!

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

I’ll try push a new release tomorrow once I’m at my laptop

@olafurpg olafurpg merged commit 20307e5 into sbt:master Dec 28, 2019
@softinio softinio deleted the add-circleci-support branch December 28, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants