Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pull out overrides to seperate file #821

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

henryiii
Copy link
Collaborator

This is getting large, so pulling it out into a file.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 92.21557% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.71%. Comparing base (681e6a2) to head (9eae8f5).

Files Patch % Lines
...rc/scikit_build_core/settings/skbuild_overrides.py 92.16% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
+ Coverage   83.67%   83.71%   +0.03%     
==========================================
  Files          73       74       +1     
  Lines        4123     4133      +10     
==========================================
+ Hits         3450     3460      +10     
  Misses        673      673              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii force-pushed the henryiii/refactor/overridesfile branch from bbfe6c8 to 9eae8f5 Compare July 22, 2024 20:17
@henryiii henryiii merged commit e86f807 into main Jul 22, 2024
51 checks passed
@henryiii henryiii deleted the henryiii/refactor/overridesfile branch July 22, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant