This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Fix recursive brace expansion #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solution is a copy from https://rosettacode.org/wiki/Brace_expansion#Python with some minor adaptions to clearer variable names and at least a sentence describing the functionality.
|
Hi @tmadlener, thanks for fixing this! I've tested it locally and it works (Travis is broken at the moment) so LGTM! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses and solves #64 and fixes the recursive expansion while keeping branches with braces in their names working as they should.
I have also run some timing tests and it basically doesn't change w.r.t. to the previous solution.
The solution is a copy from
https://rosettacode.org/wiki/Brace_expansion#Python
with some minor adaptions to clearer variable names and at least a sentence describing the functionality. I am not entirely sure about the licensing but as far as I can tell it should be OK.