Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Type loop variables" #789

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

Joao-Dionisio
Copy link
Collaborator

Reverts #758

Explicitly typing variables can lead to errors.

See the following:
image
image

The difference is bigger than SCIP's default machine epsilon, so we decided to revert these changes for now. Maybe the best option is to only type our custom types (like Variables, Expressions, etc.), which shouldn't be a problem. We lose the marginal speedup from Cython, but we still get a more robust codebase.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd85238) 61.68% compared to head (5dd5eda) 61.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #789   +/-   ##
=======================================
  Coverage   61.68%   61.68%           
=======================================
  Files          16       16           
  Lines        3255     3255           
=======================================
  Hits         2008     2008           
  Misses       1247     1247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmghannam mmghannam merged commit 5e6a747 into master Feb 8, 2024
3 checks passed
@Joao-Dionisio Joao-Dionisio deleted the revert-758-type-loop-variables branch February 14, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants