Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

change how cosign is built #22

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Conversation

JasonPowr
Copy link
Contributor

This pr is related to this #18, and this pr securesign/cosign#1, and involves changing the build-cosign image to use the correct branch in the securesign/cosign repo

@JasonPowr
Copy link
Contributor Author

JasonPowr commented Aug 25, 2023

The build-cosign job is currently failing because the release-next branch is not present in the repo, it should be after securesign/cosign#1 is merged and the update-to-head.sh script is run

This pr should not be merged securesign/cosign#1 is merged

@lance
Copy link
Member

lance commented Aug 25, 2023

The build-cosign job is currently failing because the release-next branch is not present in the repo, it should be after securesign/cosign#1 is merged and the update-to-head.sh script is run

This pr should not be merged securesign/cosign#1 is merged

If you rebase this PR, it should pick up the change in #20 (which fixes that issue), and the test should pass.

@JasonPowr JasonPowr force-pushed the change-build-cosign-job-for-midstream branch from e64ea75 to a91b498 Compare August 25, 2023 13:16
@JasonPowr
Copy link
Contributor Author

The build-cosign job is currently failing because the release-next branch is not present in the repo, it should be after securesign/cosign#1 is merged and the update-to-head.sh script is run
This pr should not be merged securesign/cosign#1 is merged

If you rebase this PR, it should pick up the change in #20 (which fixes that issue), and the test should pass.

The build-cosign job is currently failing because the release-next branch is not present in the repo, it should be after securesign/cosign#1 is merged and the update-to-head.sh script is run
This pr should not be merged securesign/cosign#1 is merged

If you rebase this PR, it should pick up the change in #20 (which fixes that issue), and the test should pass.

All good now Ill go ahead and close that other pr I opened, thanks Lance :)

@JasonPowr
Copy link
Contributor Author

Seems to be an issue building the image this way ill investigate

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lance lance merged commit a12a86f into main Sep 5, 2023
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants