Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug skuba commands hanging #1444

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Debug skuba commands hanging #1444

merged 6 commits into from
Feb 16, 2024

Conversation

AaronMoat
Copy link
Contributor

@AaronMoat AaronMoat commented Feb 10, 2024

image

^ :(

Copy link

changeset-bot bot commented Feb 10, 2024

🦋 Changeset detected

Latest commit: 1a84498

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AaronMoat AaronMoat marked this pull request as ready for review February 16, 2024 02:53
@AaronMoat AaronMoat requested review from a team as code owners February 16, 2024 02:53
@@ -1,5 +1,8 @@
#!/usr/bin/env node

// @ts-expect-error - no types
import whyIsNodeRunning from 'why-is-node-running';
Copy link
Contributor

@samchungy samchungy Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a .d.t.s for it instead:

declare module 'why-is-node-running' {
  export default function whyIsNodeRunning(): void;
}

Should work I thinks

@AaronMoat AaronMoat enabled auto-merge (squash) February 16, 2024 03:16
@AaronMoat AaronMoat merged commit cb1be85 into master Feb 16, 2024
18 checks passed
@AaronMoat AaronMoat deleted the timeout branch February 16, 2024 03:17
@seek-oss-ci seek-oss-ci mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants