Skip to content

Commit

Permalink
Merge pull request #152
Browse files Browse the repository at this point in the history
Release v0.8.2
  • Loading branch information
bsrinivas8687 authored Sep 24, 2021
2 parents fee0aca + ab651b8 commit 6c3dcc8
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 17 deletions.
2 changes: 1 addition & 1 deletion x/plan/types/msg.go
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ func (m *MsgRemoveNodeRequest) ValidateBasic() error {
if m.From == "" {
return errors.Wrap(ErrorInvalidFrom, "from cannot be empty")
}
if _, err := hubtypes.ProvAddressFromBech32(m.From); err != nil {
if _, err := sdk.AccAddressFromBech32(m.From); err != nil {
return errors.Wrapf(ErrorInvalidFrom, "%s", err)
}
if m.Id == 0 {
Expand Down
32 changes: 16 additions & 16 deletions x/plan/types/msg_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -477,53 +477,53 @@ func TestMsgRemoveNodeRequest_ValidateBasic(t *testing.T) {
true,
},
{
"invalid prefix address",
"invalid prefix from",
fields{
From: "sent1qypqxpq9qcrsszgszyfpx9q4zct3sxfq0fzduj",
From: "sentnode1qypqxpq9qcrsszgszyfpx9q4zct3sxfqelr5ey",
},
true,
},
{
"10 bytes address",
"10 bytes from",
fields{
From: "sentprov1qypqxpq9qcrsszgsutj8xr",
From: "sent1qypqxpq9qcrsszgslawd5s",
},
true,
},
{
"20 bytes address",
"20 bytes from",
fields{
From: "sentprov1qypqxpq9qcrsszgszyfpx9q4zct3sxfq877k82",
From: "sent1qypqxpq9qcrsszgszyfpx9q4zct3sxfq0fzduj",
},
true,
},
{
"30 bytes address",
"30 bytes from",
fields{
From: "sentprov1qypqxpq9qcrsszgszyfpx9q4zct3sxfqyy3zxfp9ycnjs2fsh33zgx",
From: "sent1qypqxpq9qcrsszgszyfpx9q4zct3sxfqyy3zxfp9ycnjs2fszvfck8",
},
true,
},
{
"zero id",
fields{
From: "sentprov1qypqxpq9qcrsszgszyfpx9q4zct3sxfq877k82",
From: "sent1qypqxpq9qcrsszgszyfpx9q4zct3sxfq0fzduj",
Id: 0,
},
true,
},
{
"positive id",
fields{
From: "sentprov1qypqxpq9qcrsszgszyfpx9q4zct3sxfq877k82",
From: "sent1qypqxpq9qcrsszgszyfpx9q4zct3sxfq0fzduj",
Id: 1000,
},
true,
},
{
"empty address",
fields{
From: "sentprov1qypqxpq9qcrsszgszyfpx9q4zct3sxfq877k82",
From: "sent1qypqxpq9qcrsszgszyfpx9q4zct3sxfq0fzduj",
Id: 1000,
Address: "",
},
Expand All @@ -532,7 +532,7 @@ func TestMsgRemoveNodeRequest_ValidateBasic(t *testing.T) {
{
"invalid address",
fields{
From: "sentprov1qypqxpq9qcrsszgszyfpx9q4zct3sxfq877k82",
From: "sent1qypqxpq9qcrsszgszyfpx9q4zct3sxfq0fzduj",
Id: 1000,
Address: "invalid",
},
Expand All @@ -541,7 +541,7 @@ func TestMsgRemoveNodeRequest_ValidateBasic(t *testing.T) {
{
"invalid prefix address",
fields{
From: "sentprov1qypqxpq9qcrsszgszyfpx9q4zct3sxfq877k82",
From: "sent1qypqxpq9qcrsszgszyfpx9q4zct3sxfq0fzduj",
Id: 1000,
Address: "sent1qypqxpq9qcrsszgszyfpx9q4zct3sxfq0fzduj",
},
Expand All @@ -550,7 +550,7 @@ func TestMsgRemoveNodeRequest_ValidateBasic(t *testing.T) {
{
"10 bytes address",
fields{
From: "sentprov1qypqxpq9qcrsszgszyfpx9q4zct3sxfq877k82",
From: "sent1qypqxpq9qcrsszgszyfpx9q4zct3sxfq0fzduj",
Id: 1000,
Address: "sentnode1qypqxpq9qcrsszgse4wwrm",
},
Expand All @@ -559,7 +559,7 @@ func TestMsgRemoveNodeRequest_ValidateBasic(t *testing.T) {
{
"20 bytes address",
fields{
From: "sentprov1qypqxpq9qcrsszgszyfpx9q4zct3sxfq877k82",
From: "sent1qypqxpq9qcrsszgszyfpx9q4zct3sxfq0fzduj",
Id: 1000,
Address: "sentnode1qypqxpq9qcrsszgszyfpx9q4zct3sxfqelr5ey",
},
Expand All @@ -568,7 +568,7 @@ func TestMsgRemoveNodeRequest_ValidateBasic(t *testing.T) {
{
"30 bytes address",
fields{
From: "sentprov1qypqxpq9qcrsszgszyfpx9q4zct3sxfq877k82",
From: "sent1qypqxpq9qcrsszgszyfpx9q4zct3sxfq0fzduj",
Id: 1000,
Address: "sentnode1qypqxpq9qcrsszgszyfpx9q4zct3sxfqyy3zxfp9ycnjs2fsxqglcv",
},
Expand Down

0 comments on commit 6c3dcc8

Please sign in to comment.