Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signing Ledger transactions with newer Cosmos app #238

Merged

Conversation

freak12techno
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0426831) 64.49% compared to head (2aa62da) 64.49%.
Report is 2 commits behind head on v0.11.x.

Additional details and impacted files
@@           Coverage Diff            @@
##           v0.11.x     #238   +/-   ##
========================================
  Coverage    64.49%   64.49%           
========================================
  Files           46       46           
  Lines         2366     2366           
========================================
  Hits          1526     1526           
  Misses         779      779           
  Partials        61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsrinivas8687 bsrinivas8687 merged commit 58764a0 into sentinel-official:v0.11.x Jan 8, 2024
3 checks passed
@freak12techno
Copy link
Contributor Author

@bsrinivas8687 I suggest also creating a new release, like 0.11.4 (as it's not consensus breaking), so people would be able to install it from repo instead of checking out to a specific commit and build from it

@freak12techno freak12techno deleted the fix-ledger-cosmos-go branch January 8, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants