Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logout function to receive a HeadersInit #271

Merged
merged 2 commits into from
May 30, 2024
Merged

Allow logout function to receive a HeadersInit #271

merged 2 commits into from
May 30, 2024

Conversation

reichhartd
Copy link
Contributor

@reichhartd reichhartd commented Mar 4, 2024

This PR modifies the logout functionality to handle the deletion of additional cookies beyond the authentication cookie managed by remix-auth.

Changes:

  • Introduced an optional headers parameter to the logout function.
  • Integrated the ability to set multiple Set-Cookie headers, allowing for the clearing of various session cookies.

This enhancement is crucial for instances where multiple cookies are used and need to be cleared to ensure a user is completely logged out.

@reichhartd reichhartd changed the title enhancement: Extend logout to allow multiple Cookie Removal Extend logout to allow multiple cookie removal Mar 4, 2024
@reichhartd
Copy link
Contributor Author

@sergiodxa Maybe you can find time to look over this small PR? 🙂

src/authenticator.ts Outdated Show resolved Hide resolved
src/authenticator.ts Outdated Show resolved Hide resolved
@sergiodxa sergiodxa added the enhancement New feature or request label May 30, 2024
@sergiodxa sergiodxa changed the title Extend logout to allow multiple cookie removal Allow logout function to receive a HeadersInit May 30, 2024
@sergiodxa sergiodxa merged commit 8b52021 into sergiodxa:main May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants