Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Load should (?) return a xr.Dataset instead of a dict #88

Closed
remi-braun opened this issue Apr 19, 2023 · 1 comment
Closed

ENH: Load should (?) return a xr.Dataset instead of a dict #88

remi-braun opened this issue Apr 19, 2023 · 1 comment
Labels
0.21.0 For version 0.21.0 enhancement New feature or request

Comments

@remi-braun
Copy link
Member

remi-braun commented Apr 19, 2023 •
edited
Loading

For now, the result of the load function is a dictionary.
This is a bit oldschool.

It would be maybe better to replace the dict object by a xr.Dataset. The access to the bands wouldn't change.
@remi-braun remi-braun added the enhancement New feature or request label Apr 19, 2023
@remi-braun remi-braun changed the title Replace dict bu xr.Dataset ENH: Load should (?) return a xr.Dataset instead of a dict Apr 19, 2023
@remi-braun
Copy link
Member Author

Don't forget to add all relevant attributes to the dataset

remi-braun added a commit that referenced this issue Apr 20, 2023
@remi-braun
BREAKING CHANGES: load function now returns a xarray.Dataset** #88
0509c8e
@remi-braun remi-braun added the 0.21.0 For version 0.21.0 label Apr 25, 2023
bastiencyr pushed a commit to bastiencyr/eoreader that referenced this issue May 30, 2023
@remi-braun
BREAKING CHANGES: load function now returns a xarray.Dataset** se…
94db4df 
…rtit#88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.21.0 For version 0.21.0 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@remi-braun