Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Error::description #574

Conversation

AnderEnder
Copy link

Error::description has been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon.

This PR:

  • Moves an implementation of Error::description into internal ParseError type implementation similar to SyntaxViolation

Related PR: rust-lang/rust#66919

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably e003e93) made this pull request unmergeable. Please resolve the merge conflicts.

@djc
Copy link
Contributor

djc commented Aug 18, 2020

I've fixed this in a slightly different way in c9a7003. Thanks!

@djc djc closed this Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants