Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally force HTTPS content URIs in secure contexts #1389

Closed
joeyparrish opened this issue Apr 3, 2018 · 0 comments · Fixed by #3025
Closed

Optionally force HTTPS content URIs in secure contexts #1389

joeyparrish opened this issue Apr 3, 2018 · 0 comments · Fixed by #3025
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v3.1

Comments

@joeyparrish
Copy link
Member

While debugging a content issue with a partner, we found that the DASH manifest contained plain HTTP URIs. When the page is loaded in a secure context, this causes mixed content errors.

We could add an option that would override http URIs with https URIs when the page context is https. This might be useful for some applications whose packager produces absolute, plain HTTP URIs (as bitmovin seems to do in this case).
@joeyparrish joeyparrish added type: enhancement New feature or request flag: good first issue This might be a relatively easy issue; good for new contributors labels Apr 3, 2018
@joeyparrish joeyparrish added this to the v2.5 milestone Apr 3, 2018
@joeyparrish joeyparrish modified the milestones: v2.5, Backlog Jul 9, 2018
@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
@avelad avelad mentioned this issue Dec 3, 2020
Merged
joeyparrish pushed a commit that referenced this issue Dec 17, 2020
feat: Optionally force HTTPS content URIs (#3025)
207c235 
Closes: #1389
@joeyparrish joeyparrish modified the milestones: Backlog, v3.1 Dec 23, 2020
@shaka-project shaka-project locked and limited conversation to collaborators Feb 15, 2021
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v3.1
Development

Successfully merging a pull request may close this issue.

Optionally force HTTPS content URIs avelad/shaka-player
2 participants
@joeyparrish @shaka-bot